From: Vladimir Oltean <olteanv@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, Woojung Huh <woojung.huh@microchip.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Michael Walle <michael@walle.cc>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Oleksij Rempel <linux@rempel-privat.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net v4] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C)
Date: Wed, 6 Sep 2023 01:29:45 +0300 [thread overview]
Message-ID: <20230905222945.h7tuzlraxdp5imbh@skbuf> (raw)
In-Reply-To: <20230905093315.784052-1-lukma@denx.de>
On Tue, Sep 05, 2023 at 11:33:15AM +0200, Lukasz Majewski wrote:
> @@ -1847,6 +1844,12 @@ static int ksz9477_config_init(struct phy_device *phydev)
> return err;
> }
>
> + /* According to KSZ9477 Errata DS80000754C (Module 4) all EEE modes
> + * in this switch shall be regarded as broken.
> + */
> + if (phydev->dev_flags & MICREL_NO_EEE)
> + phydev->eee_broken_modes = -1;
I know this is just another quick'n'dirty code snippet exchanged over
email which turned into a proper patch, but wouldn't it be more
civilized to use "MDIO_EEE_100TX | MDIO_EEE_1000T" here, than to declare
EEE broken for link modes which aren't even supported by the internal
switch PHYs?
It's probably not causing practical harm, but currently, we tell
genphy_config_eee_advert() to include reserved bits of the MMD EEE
Advertising Register (MMD 0x07 : 0x3C) into its modification mask.
next prev parent reply other threads:[~2023-09-05 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 9:33 Lukasz Majewski
2023-09-05 20:48 ` Jakub Kicinski
2023-09-06 7:33 ` Lukasz Majewski
2023-09-05 21:58 ` Florian Fainelli
2023-09-05 22:29 ` Vladimir Oltean [this message]
2023-09-06 6:40 ` Russell King (Oracle)
2023-09-07 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905222945.h7tuzlraxdp5imbh@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=lukma@denx.de \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®