From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B786BCCF9E9 for ; Wed, 6 Sep 2023 00:00:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243149AbjIFAAR (ORCPT ); Tue, 5 Sep 2023 20:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233081AbjIFAAR (ORCPT ); Tue, 5 Sep 2023 20:00:17 -0400 Received: from out-222.mta1.migadu.com (out-222.mta1.migadu.com [IPv6:2001:41d0:203:375::de]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D85961B4 for ; Tue, 5 Sep 2023 17:00:13 -0700 (PDT) Date: Tue, 5 Sep 2023 20:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693958411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8poP0+BOtpoVUDo/ffAuM+DGPWtHYPwwwl3cE296KF4=; b=TwcVHaQ5B4SHn6QILjJegzt3LYRXdqCuY2stDxsG792+AswUiElKKQ5MNx5gXNTmzfxd82 I36nFVkBpfooBTL6xht6UknTMUaQHi0LGgxY/rsK9Ai3QHXYQPa2zzZvVp3iRcNuu13tbO 5qXSxuA5fICZY5Lm6oA958AsDFPY4CE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Christian Brauner Subject: Re: [GIT PULL] bcachefs Message-ID: <20230906000007.ry5rmk35vt57kppx@moria.home.lan> References: <20230903032555.np6lu5mouv5tw4ff@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 05, 2023 at 06:24:47AM -0700, Christoph Hellwig wrote: > Hi Kent, > > I thought you'd follow Christians proposal to actually work with > people to try to use common APIs (i.e. to use iomap once it's been > even more iter-like, for which I'm still waiting for suggestions), > and make your new APIs used more widely if they are a good idea > (which also requires explaining them better) and aim for 6.7 once > that is done. Christoph, I get that iomap is your pet project and you want to make it better and see it more widely used. But the reasons bcachefs doesn't use iomap have been discussed at length, and I've posted and talked about the bcachefs equivalents of that code. You were AWOL on those discussions; you consistently say "bcachefs should use iomap" and then walk away, so those discussions haven't moved forwards. To recap, besides being more iterator like (passing data structures around with iterators, vs. indirect function calls into the filesystem), bcachefs also hangs a bit more state off the pagecache, due to being multi device and also using the same data structure for tracking disk reservations (because why make the buffered write paths look that up separately?). > But without that, and without being in linux-next and the VFS maintainer > ACK required for I think this is a very bad idea. Christain gave his reviewed-by for the dcache patch. Since this patchset doesn't change existing code maintained by others aside from that one patch, not sure how linux-next is relevant here...