From: Peter Zijlstra <peterz@infradead.org>
To: Leonardo Bras <leobras@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>, Guo Ren <guoren@kernel.org>,
Valentin Schneider <vschneid@redhat.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Juergen Gross <jgross@suse.com>,
Yury Norov <yury.norov@gmail.com>,
Imran Khan <imran.f.khan@oracle.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] smp: Change function signatures to use call_single_data_t
Date: Wed, 6 Sep 2023 16:09:47 +0200 [thread overview]
Message-ID: <20230906140947.GA33104@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230831063129.335425-1-leobras@redhat.com>
On Thu, Aug 31, 2023 at 03:31:28AM -0300, Leonardo Bras wrote:
> call_single_data_t is a size-aligned typedef of struct __call_single_data.
>
> This alignment is desirable in order to have smp_call_function*() avoid
> bouncing an extra cacheline in case of an unaligned csd, given this
> would hurt performance.
>
> Since the removal of struct request->csd in commit 660e802c76c8
> ("blk-mq: use percpu csd to remote complete instead of per-rq csd") there
> are no current users of smp_call_function*() with unaligned csd.
>
> Change every 'struct __call_single_data' function parameter to
> 'call_single_data_t', so we have warnings if any new code tries to
> introduce an smp_call_function*() call with unaligned csd.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
Fair enough, I'll go queue it somewhere.
next prev parent reply other threads:[~2023-09-06 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 6:31 Leonardo Bras
2023-08-31 6:58 ` Guo Ren
2023-09-01 6:17 ` Leonardo Bras Soares Passos
2023-09-06 14:09 ` Peter Zijlstra [this message]
2023-09-06 16:15 ` Leonardo Bras Soares Passos
2023-09-12 10:29 ` [tip: smp/core] " tip-bot2 for Leonardo Bras
2023-09-13 13:03 ` tip-bot2 for Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906140947.GA33104@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=guoren@kernel.org \
--cc=imran.f.khan@oracle.com \
--cc=jgross@suse.com \
--cc=jpoimboe@kernel.org \
--cc=leobras@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®