mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Jim Cromie <jim.cromie@gmail.com>,
	apw@canonical.com, joe@perches.com,
	Kees Cook <keescook@chromium.org>
Subject: [PATCH 2/2] checkpatch: reword long-line warning about commit-msg
Date: Thu,  7 Sep 2023 11:45:06 -0600	[thread overview]
Message-ID: <20230907174506.593889-1-jim.cromie@gmail.com> (raw)

The COMMIT_LOG_LONG_LINE warning complains about:
 1- possible unwrapped commit description
 2- line too long

The actual test is #2, so reword it to say that 1st.
This could reduce potential confusion for newbie users.

Cc: apw@canonical.com
Cc: joe@perches.com
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6aabcc1f66c1..6e789dc07420 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3272,7 +3272,7 @@ sub process {
 					# A Fixes:, link or signature tag line
 		      $commit_log_possible_stack_dump)) {
 			WARN("COMMIT_LOG_LONG_LINE",
-			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
+			     "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);
 			$commit_log_long_line = 1;
 		}
 
-- 
2.41.0


             reply	other threads:[~2023-09-07 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 17:45 Jim Cromie [this message]
2023-09-07 18:19 ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2023-08-08  3:30 [PATCH 0/2] checkpatch tweaks Jim Cromie
2023-08-08  3:30 ` [PATCH 2/2] checkpatch: reword long-line warning about commit-msg Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907174506.593889-1-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®