From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B43EE57EB for ; Fri, 8 Sep 2023 11:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239971AbjIHLhI (ORCPT ); Fri, 8 Sep 2023 07:37:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjIHLhH (ORCPT ); Fri, 8 Sep 2023 07:37:07 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 547F01BE7 for ; Fri, 8 Sep 2023 04:37:03 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeZnF-0007tr-F7; Fri, 08 Sep 2023 13:36:57 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qeZnE-004rrl-2v; Fri, 08 Sep 2023 13:36:56 +0200 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qeZnD-003K9l-Gt; Fri, 08 Sep 2023 13:36:55 +0200 Date: Fri, 8 Sep 2023 13:36:55 +0200 From: Sascha Hauer To: Ping-Ke Shih Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kalle Valo , Yanik Fuchs Subject: Re: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM Message-ID: <20230908113655.GF637806@pengutronix.de> References: <20230907071614.2032404-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2023 at 12:23:13AM +0000, Ping-Ke Shih wrote: > > > > -----Original Message----- > > From: Sascha Hauer > > Sent: Thursday, September 7, 2023 3:16 PM > > To: linux-wireless@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org; Kalle Valo ; Ping-Ke Shih ; Yanik > > Fuchs > > Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM > > > > The MAC address is stored at offset 0x107 in the EEPROM, like correctly > > stated in the comment. Add a two bytes reserved field right before the > > MAC address to shift it from offset 0x105 to 0x107. > > > > With this the MAC address returned from my RTL8723du wifi stick can be > > correctly decoded as "Shenzhen Four Seas Global Link Network Technology > > Co., Ltd." > > With this correctness, my stick can be recognized as: > " Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter" It should be recognized like this also without this patch, but with this patch the MAC address should be read correctly. > > Should it add a Fixes tag? > Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support") Yes, I forgot this. Kalle, can you add it once again while applying? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |