From: Sagi Shahar <sagis@google.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Vishal Annapurve <vannapurve@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
Nikolay Borisov <nik.borisov@suse.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Sagi Shahar <sagis@google.com>
Subject: [PATCH] x86/tdx: Allow extended topology CPUID leafs to be emulated by hypercall
Date: Fri, 8 Sep 2023 10:56:44 -0700 [thread overview]
Message-ID: <20230908175644.2478924-1-sagis@google.com> (raw)
The current TDX module does not handle extended topology leaves
explicitly and will generate a #VE but the current #VE handler
implementation blindly returns 0 for those CPUID leaves.
This currently causes TDX guests to see 0 values when querying the numa
topology leading to incorrect numa configurations.
This patch fixes this behavior by emulating the extended topology leaves
using the CPUID hypercall.
Change-Id: I427807e3ac8d9e3be50a6fac40ebd3f54b445b0c
Signed-off-by: Sagi Shahar <sagis@google.com>
---
arch/x86/coco/tdx/tdx.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
index 1d6b863c42b0..db9a4673555a 100644
--- a/arch/x86/coco/tdx/tdx.c
+++ b/arch/x86/coco/tdx/tdx.c
@@ -321,13 +321,16 @@ static int handle_cpuid(struct pt_regs *regs, struct ve_info *ve)
};
/*
- * Only allow VMM to control range reserved for hypervisor
- * communication.
+ * Only emulate CPUID in 2 cases:
+ * - CPUID is in the range reserved for hypervisor communication.
+ * - CPUID is an extended topology leaf which is not emulated natively
+ * by the TDX module.
*
- * Return all-zeros for any CPUID outside the range. It matches CPU
- * behaviour for non-supported leaf.
+ * Return all-zeros for any other CPUID. It matches CPU behaviour for
+ * non-supported leaf.
*/
- if (regs->ax < 0x40000000 || regs->ax > 0x4FFFFFFF) {
+ if ((regs->ax < 0x40000000 || regs->ax > 0x4FFFFFFF) &&
+ regs->ax != 0x0b && regs->ax != 0x1f) {
regs->ax = regs->bx = regs->cx = regs->dx = 0;
return ve_instr_len(ve);
}
--
2.42.0.283.g2d96d420d3-goog
next reply other threads:[~2023-09-08 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 17:56 Sagi Shahar [this message]
2023-09-08 18:00 ` Dave Hansen
2023-09-08 19:25 ` Sagi Shahar
2023-09-08 22:24 ` Dave Hansen
2023-09-09 10:14 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908175644.2478924-1-sagis@google.com \
--to=sagis@google.com \
--cc=Jason@zx2c4.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=erdemaktas@google.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vannapurve@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®