From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Lu Hongfei <luhongfei@vivo.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sasha Levin <sashal@kernel.org>,
mchehab@kernel.org, matthias.bgg@gmail.com,
moudy.ho@mediatek.com, krzysztof.kozlowski@linaro.org,
sunke32@huawei.com, drv@mailo.com, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH AUTOSEL 6.1 01/24] media: mdp3: Fix resource leaks in of_find_device_by_node
Date: Fri, 8 Sep 2023 20:37:53 -0400 [thread overview]
Message-ID: <20230909003818.3580081-1-sashal@kernel.org> (raw)
From: Lu Hongfei <luhongfei@vivo.com>
[ Upstream commit 35ca8ce495366909b4c2e701d1356570dd40c4e2 ]
Use put_device to release the object get through of_find_device_by_node,
avoiding resource leaks.
Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index 7bc05f42a23c1..9a3f46c1f6ba3 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -775,11 +775,13 @@ static int mdp_get_subsys_id(struct device *dev, struct device_node *node,
ret = cmdq_dev_get_client_reg(&comp_pdev->dev, &cmdq_reg, index);
if (ret != 0) {
dev_err(&comp_pdev->dev, "cmdq_dev_get_subsys fail!\n");
+ put_device(&comp_pdev->dev);
return -EINVAL;
}
comp->subsys_id = cmdq_reg.subsys;
dev_dbg(&comp_pdev->dev, "subsys id=%d\n", cmdq_reg.subsys);
+ put_device(&comp_pdev->dev);
return 0;
}
--
2.40.1
next reply other threads:[~2023-09-09 0:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 0:37 Sasha Levin [this message]
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 02/24] media: dvb-usb-v2: af9035: Fix null-ptr-deref in af9035_i2c_master_xfer Sasha Levin
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 03/24] media: dw2102: Fix null-ptr-deref in dw2102_i2c_transfer() Sasha Levin
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 04/24] media: af9005: Fix null-ptr-deref in af9005_i2c_xfer Sasha Levin
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 05/24] media: anysee: fix null-ptr-deref in anysee_master_xfer Sasha Levin
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 06/24] media: az6007: Fix null-ptr-deref in az6007_i2c_xfer() Sasha Levin
2023-09-09 0:37 ` [PATCH AUTOSEL 6.1 07/24] media: dvb-usb-v2: gl861: Fix null-ptr-deref in gl861_i2c_master_xfer Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 08/24] iio: core: Use min() instead of min_t() to make code more robust Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 09/24] scsi: lpfc: Abort outstanding ELS cmds when mailbox timeout error is detected Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 10/24] media: tuners: qt1010: replace BUG_ON with a regular error Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 11/24] media: pci: cx23885: replace BUG with error return Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 12/24] usb: cdns3: Put the cdns set active part outside the spin lock Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 13/24] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 14/24] tools: iio: iio_generic_buffer: Fix some integer type and calculation Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 15/24] scsi: target: iscsi: Fix buffer overflow in lio_target_nacl_info_show() Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 16/24] serial: cpm_uart: Avoid suspicious locking Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 17/24] misc: open-dice: make OPEN_DICE depend on HAS_IOMEM Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 18/24] workqueue: Call wq_update_unbound_numa() on all CPUs in NUMA node on CPU hotplug Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 19/24] usb: ehci: add workaround for chipidea PORTSC.PEC bug Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 20/24] usb: chipidea: add workaround for chipidea PEC bug Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 21/24] media: pci: ipu3-cio2: Initialise timing struct to avoid a compiler warning Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 22/24] kobject: Add sanity check for kset->kobj.ktype in kset_register() Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 23/24] interconnect: Fix locking for runpm vs reclaim Sasha Levin
2023-09-09 0:38 ` [PATCH AUTOSEL 6.1 24/24] usb: cdc-acm: move ldisc dcd notification outside of acm's read lock Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909003818.3580081-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=drv@mailo.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luhongfei@vivo.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®