From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24412EEB57C for ; Sat, 9 Sep 2023 00:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343737AbjIIAwB (ORCPT ); Fri, 8 Sep 2023 20:52:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241399AbjIIAv7 (ORCPT ); Fri, 8 Sep 2023 20:51:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E65E1FFF; Fri, 8 Sep 2023 17:51:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ECB5C07616; Sat, 9 Sep 2023 00:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694220029; bh=AhEs6vY+78I9JdY7xnb1aTPitXnMUmJ1Fz3Jl4w0ULs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MgveaEQ4Ih0zsjV7poUr2lmUT/+ddR1osniYOZvpRXXV9VMq/f6W0Bz3JM/u96Gbk BUO0BCRvqmgJRcJ6RkinyaoWLvL7Tusod5w1iKJ/eHskquWYGNSPPmzJ461b9tmtEp HZdLfKm8T24QCi14H+DNKlLGPDOSDDUaAqotLZrvs0SNv4xrXFNLzjlpjXSBw7OoOx L12Erme/+TnRPR/x8N1kEnCNjmlhjErHAR/THO0jcpThXGcTJ7uSS/5vYVvXJvNmfk gRNgxaaPRSIehBicTGnjndV5zaXZoxI5V3jtbq90qYRw4sdgLIwgTPrw7AJv1G7Ep3 P5jOvA5Y7jLUA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , Sasha Levin , crope@iki.fi, mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 07/14] media: tuners: qt1010: replace BUG_ON with a regular error Date: Fri, 8 Sep 2023 20:40:07 -0400 Message-Id: <20230909004015.3580832-7-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230909004015.3580832-1-sashal@kernel.org> References: <20230909004015.3580832-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.256 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit ee630b29ea44d1851bb6c903f400956604834463 ] BUG_ON is unnecessary here, and in addition it confuses smatch. Replacing this with an error return help resolve this smatch warning: drivers/media/tuners/qt1010.c:350 qt1010_init() error: buffer overflow 'i2c_data' 34 <= 34 Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/tuners/qt1010.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/tuners/qt1010.c b/drivers/media/tuners/qt1010.c index e48faf942830c..624499fb71b92 100644 --- a/drivers/media/tuners/qt1010.c +++ b/drivers/media/tuners/qt1010.c @@ -342,11 +342,12 @@ static int qt1010_init(struct dvb_frontend *fe) else valptr = &tmpval; - BUG_ON(i >= ARRAY_SIZE(i2c_data) - 1); - - err = qt1010_init_meas1(priv, i2c_data[i+1].reg, - i2c_data[i].reg, - i2c_data[i].val, valptr); + if (i >= ARRAY_SIZE(i2c_data) - 1) + err = -EIO; + else + err = qt1010_init_meas1(priv, i2c_data[i + 1].reg, + i2c_data[i].reg, + i2c_data[i].val, valptr); i++; break; } -- 2.40.1