mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow <davidgow@google.com>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: "Maíra Canal" <mairacanal@riseup.net>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Maxime Ripard" <mripard@kernel.org>
Subject: [PATCH 0/2] drm/tests: Flag slow kunit tests as such
Date: Mon, 11 Sep 2023 11:51:04 +0200	[thread overview]
Message-ID: <20230911-kms-slow-tests-v1-0-d3800a69a1a1@kernel.org> (raw)

Hi,

Here's a series that sets the speed attribute to slow on DRM tests that
are taking a while to execute.

With those patches, an initial run of the drm tests on arm64 were taking
59s to execute with:

$ ./tools/testing/kunit/kunit.py run \
	--kunitconfig=drivers/gpu/drm/tests \
	--arch arm64 \
	--cross_compile aarch64-linux-gnu-
...
[11:50:07] Testing complete. Ran 340 tests: passed: 340
[11:50:07] Elapsed time: 62.261s total, 0.001s configuring, 2.703s building, 59.532s running

and are now taking 1.7s when filtering out the slow tests:

$ ./tools/testing/kunit/kunit.py run \
	--kunitconfig=drivers/gpu/drm/tests \
	--arch arm64 \
	--cross_compile aarch64-linux-gnu- \
	--filter "speed>slow"
...
[11:47:52] Testing complete. Ran 332 tests: passed: 332
[11:47:52] Elapsed time: 6.449s total, 0.001s configuring, 4.728s building, 1.678s running

Let me know what you think,
Maxime

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Maxime Ripard (2):
      kunit: Warn if tests are slow
      drm/tests: Flag slow tests as such

 drivers/gpu/drm/tests/drm_buddy_test.c |  2 +-
 drivers/gpu/drm/tests/drm_mm_test.c    | 14 +++++++-------
 lib/kunit/test.c                       | 16 ++++++++++++++++
 3 files changed, 24 insertions(+), 8 deletions(-)
---
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
change-id: 20230911-kms-slow-tests-0261bee9a54b

Best regards,
-- 
Maxime Ripard <mripard@kernel.org>


             reply	other threads:[~2023-09-11 21:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11  9:51 Maxime Ripard [this message]
2023-09-11  9:51 ` [PATCH 1/2] kunit: Warn if tests are slow Maxime Ripard
2023-09-11 10:07   ` Jani Nikula
2023-09-11 11:25     ` Maxime Ripard
2023-09-19 19:48   ` Rae Moar
2023-09-20  7:06     ` Maxime Ripard
2023-09-11  9:51 ` [PATCH 2/2] drm/tests: Flag slow tests as such Maxime Ripard
2023-09-12  7:36   ` Daniel Vetter
2023-09-14 13:24     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230911-kms-slow-tests-v1-0-d3800a69a1a1@kernel.org \
    --to=mripard@kernel.org \
    --cc=airlied@gmail.com \
    --cc=brendan.higgins@linux.dev \
    --cc=daniel@ffwll.ch \
    --cc=davidgow@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mairacanal@riseup.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®