From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF35CA0EC8 for ; Mon, 11 Sep 2023 21:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354788AbjIKVzX (ORCPT ); Mon, 11 Sep 2023 17:55:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237316AbjIKMfb (ORCPT ); Mon, 11 Sep 2023 08:35:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB11E1B9; Mon, 11 Sep 2023 05:35:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 174C7C433C7; Mon, 11 Sep 2023 12:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694435726; bh=P2X5HQVGLxoGcauLnK65kalfLdiRnwUpcJ4JOMx8SDk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WDGOEY8n+o4nUr3QOuEV25GHkRhk6CpylfXgLn6xWNr10ZrRwAR1taHVxwVGczTN0 6ESL6Aq+u7FlnD2LzuBZIU4ORq82xWOYcF1hiJbDmr9JjFmp2KxXMDQeGwcN6XyLX5 pgkOYENb8sLyV3Z0gfXYLW+4FR3VJqUKSpFTX5GglujnStzQDM1smoSCO1ASZEeGJi o0lipQxL7OhONqByvQfmWGzxZ5AGPS3FaTZTXrc4lRJ5TqhttSae9kEPzVPPVd1i8e 9AjujS95uFldbPm08DUgkltv6LxDdRmJyDpHPuHh+lnocLft9ITJmwdNfK2dJVP2rm ZLxi4u32tpVmg== Date: Mon, 11 Sep 2023 14:35:15 +0200 From: Christian Brauner To: Michael =?utf-8?B?V2Vpw58=?= Cc: Alexander Mikhalitsyn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Quentin Monnet , Alexander Viro , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, gyroidos@aisec.fraunhofer.de, paul@paul-moore.com, Miklos Szeredi , Amir Goldstein Subject: Re: [PATCH RFC 1/4] bpf: add cgroup device guard to flag a cgroup device prog Message-ID: <20230911-leerstand-letztendlich-043fab663451@brauner> References: <20230814-devcg_guard-v1-0-654971ab88b1@aisec.fraunhofer.de> <20230814-devcg_guard-v1-1-654971ab88b1@aisec.fraunhofer.de> <20230815-feigling-kopfsache-56c2d31275bd@brauner> <20230817221102.6hexih3uki3jf6w3@macbook-pro-8.dhcp.thefacebook.com> <20230904-harfe-haargenau-4c6cb31c304a@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So are OK with the checks here? I'm ok with figuring out whether we can do this nicely, yes. > > Because right now device access management seems its own form of > > mandatory access control. > > I'm currently testing an updated version which has incorporated the locking > changes already mention by Alex and the change which avoids setting SB_I_NODEV > in fs/super.c. Not having to hack around SB_I_NODEV would be pretty crucial imho. It's a core security assumption so we need to integrate with it nicely.