From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03768EE3F1C for ; Mon, 11 Sep 2023 20:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbjIKUtb (ORCPT ); Mon, 11 Sep 2023 16:49:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237653AbjIKNFY (ORCPT ); Mon, 11 Sep 2023 09:05:24 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FC51DF for ; Mon, 11 Sep 2023 06:05:19 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38BD4WjN020555; Mon, 11 Sep 2023 08:04:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694437472; bh=l3EsvSktChO7TrFPn0emVwsdyYD0XfMxdQQKc9ZTbHk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=RgrZJ6I5abBlaqQ0Lct0j5m+QJXF5iPD34MARIPidmmM6bVGTvzIu97IcjAsHUA7J eIjybEqc2UldeP7u6MDqSDOC4QiEwhesJhFDa5muMM1QBzQqPn9Na0LV47pqFeW3ML GEr/2yxIV3cceV0fg/dVh9LJjCuFLSBQQY7Al95o= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38BD4Wq9006471 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 Sep 2023 08:04:32 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 11 Sep 2023 08:04:31 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 11 Sep 2023 08:04:31 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38BD4VYn029854; Mon, 11 Sep 2023 08:04:31 -0500 Date: Mon, 11 Sep 2023 08:04:31 -0500 From: Nishanth Menon To: Linus Walleij CC: "Russell King (Oracle)" , Andrew Davis , Zhizhou Zhang , , , , , , , , , Zhizhou Zhang Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Message-ID: <20230911130431.k35xp7gszgwqigl4@vendetta> References: <20230907143302.4940-1-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23:00-20230908, Linus Walleij wrote: > On Fri, Sep 8, 2023 at 3:50 PM Russell King (Oracle) > wrote: > > > However, it makes a total nonsense of the comment, which explains > > precisely why the flush_cache_all() is where it is. Moving it before > > that comment means that the comment is now rediculous. > > Zhizhou, can you look over the comment placement? > > > So, please don't put it in the patch system. > > > > The patch certainly needs to be tested on TI Keystone which is the > > primary user of this code. > > Added Andrew Davis and Nishanth Menon to the thread: > can you folks review and test this for Keystone? next-20230911 alone: (boots fine): https://gist.github.com/nmenon/c097b4a7ce3971964a5a56a34b018c4d With https://lore.kernel.org/all/20230907143302.4940-1-zhizhou.zh@gmail.com/ applied on top (fails to boot): https://gist.github.com/nmenon/308cfeb84098f41d340cd0e61845a507 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D