From: Andrew Morton <akpm@linux-foundation.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Chuck Lever <cel@kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Neil Brown <neilb@suse.de>,
Liam Howlett <liam.howlett@oracle.com>,
Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Gow <davidgow@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 11/17] lib: add light-weight queuing mechanism.
Date: Mon, 11 Sep 2023 14:04:39 -0700 [thread overview]
Message-ID: <20230911140439.b273bf9e120881f038da0de7@linux-foundation.org> (raw)
In-Reply-To: <4D5C2693-40E9-467D-9F2F-59D92CBE9D3B@oracle.com>
On Mon, 11 Sep 2023 20:30:40 +0000 Chuck Lever III <chuck.lever@oracle.com> wrote:
>
>
> > On Sep 11, 2023, at 2:13 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Mon, 11 Sep 2023 10:39:43 -0400 Chuck Lever <cel@kernel.org> wrote:
> >
> >> lwq is a FIFO single-linked queue that only requires a spinlock
> >> for dequeueing, which happens in process context. Enqueueing is atomic
> >> with no spinlock and can happen in any context.
> >
> > What is the advantage of this over using one of the library
> > facilities which we already have?
>
> I'll let the patch author respond to that question, but let me pose
> one of my own: What pre-existing facilities are you thinking of, so
> that I may have a look?
Well, I assume that plain old list_heads could be recruited for this
requirement. And I hope that a FIFO could be implemented using kfifo ;)
next prev parent reply other threads:[~2023-09-12 2:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 14:38 [PATCH v1 00/17] RPC service thread improvements Chuck Lever
2023-09-11 14:39 ` [PATCH v1 11/17] lib: add light-weight queuing mechanism Chuck Lever
2023-09-11 18:13 ` Andrew Morton
2023-09-11 20:30 ` Chuck Lever III
2023-09-11 21:04 ` Andrew Morton [this message]
2023-09-11 23:19 ` NeilBrown
2023-09-12 1:30 ` Andrew Morton
2023-09-14 14:05 ` Chuck Lever III
2023-09-15 1:51 ` NeilBrown
2023-09-15 2:22 ` [PATCH 11/17 SQUASH and replace commit message] " NeilBrown
2023-09-15 15:54 ` Chuck Lever III
2023-09-12 2:37 ` [PATCH v1 11/17] " Kees Cook
2023-09-12 4:08 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911140439.b273bf9e120881f038da0de7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®