mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Shuah Khan <shuah@kernel.org>,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
	Beau Belgrave <beaub@linux.microsoft.com>,
	Ira Weiny <ira.weiny@intel.com>,
	linux-kselftest@vger.kernel.org, stable@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] tracing/user_events: fix long size check in the ABI selftest
Date: Mon, 11 Sep 2023 18:09:35 +0200	[thread overview]
Message-ID: <20230911160935.10720-1-aleksander.lobakin@intel.com> (raw)

The current check for 64-bit architecture is double-bugged.
First of all, %BITS_PER_LONG is not available in the userspace,
the underscored version from <asm/bitsperlong.h> must be used.
The following check:

 #if BITS_PER_LONG == 0
 #error
 #endif

triggers the error in this source file -- the macro is undefined and
thus is implicitly evaluated to 0.
Next, %BITS_PER_LONG means "bits", not "bytes". In the Linux kernel,
it can be 32 or 64, never 8. Given that the tests guarded by that check
are meant to be run on a 64-bit system, the correct value would be 64.

Prefix the macro name and fix the value it's compared to.

Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
Cc: stable@vger.kernel.org # 6.4+
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
---
 tools/testing/selftests/user_events/abi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/user_events/abi_test.c b/tools/testing/selftests/user_events/abi_test.c
index 5125c42efe65..4b30461fc741 100644
--- a/tools/testing/selftests/user_events/abi_test.c
+++ b/tools/testing/selftests/user_events/abi_test.c
@@ -129,7 +129,7 @@ TEST_F(user, bit_sizes) {
 	ASSERT_EQ(0, reg_disable(&self->check, 0));
 	ASSERT_EQ(0, reg_disable(&self->check, 31));
 
-#if BITS_PER_LONG == 8
+#if __BITS_PER_LONG == 64
 	/* Allow 0-64 bits for 64-bit */
 	ASSERT_EQ(0, reg_enable(&self->check, sizeof(long), 63));
 	ASSERT_NE(0, reg_enable(&self->check, sizeof(long), 64));
-- 
2.41.0


             reply	other threads:[~2023-09-11 22:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 16:09 Alexander Lobakin [this message]
2023-09-13 10:07 ` Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230911160935.10720-1-aleksander.lobakin@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=beaub@linux.microsoft.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®