From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment
Date: Mon, 11 Sep 2023 20:57:18 -0400 [thread overview]
Message-ID: <20230911205718.5bc23f8d@gandalf.local.home> (raw)
In-Reply-To: <20230912095457.e5b89f84e168ed06072ea3d5@kernel.org>
On Tue, 12 Sep 2023 09:54:57 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > Shouldn't the above be:
> >
> > if [ ! -z "${UNMOUNT_DIR}" ]; then
> >
> > ?
>
> I think both are good.
> What about using '-n' explictly?
>
> [ -n "${UNMOUNT_DIR}" ]
Even better. Heh, I never even knew about that switch :-p
-- Steve
prev parent reply other threads:[~2023-09-12 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 9:36 Masami Hiramatsu (Google)
2023-09-11 17:09 ` Steven Rostedt
2023-09-12 0:54 ` Masami Hiramatsu
2023-09-12 0:57 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911205718.5bc23f8d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®