From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29DECA0ECB for ; Mon, 11 Sep 2023 21:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245020AbjIKVIj (ORCPT ); Mon, 11 Sep 2023 17:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242416AbjIKPcZ (ORCPT ); Mon, 11 Sep 2023 11:32:25 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F66DE5 for ; Mon, 11 Sep 2023 08:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694446341; x=1725982341; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding; bh=3INpuqFv6Nf0RI0BKSokgQC3jf5Kgn+0u3G7TKtjRns=; b=h/QEG8UzzOnjZ9KUwUTJWKy9O8H6ef3s5uY4y+s+z4AUchDutEcMvAh9 IF2s7hHapPDBmhGpF2UvHDIF5FOe0gD7J1lHuTc3Sp1Fjsc1GcvOi6GCv KNSLfsC8UfgRuiAz6Sz7p0BSNopremyyxv9CSqfBw6RNcuT7t8IeQtjA8 XD6imunQg0cw7KkK+67LmqwYOBYf7Pn7L4BGLeCkzchze6hNc6tAs402+ V00isVMeUpzmHM90F9q3pnz7zger5vsLbRA/j8G8ZIE6C2bjR07Lj7Sj2 LkCgl9gK2vk4/RR5/YIKZrzyfRLZQZwhXvID3Ydnz5HExU5ANG5EFFh6m g==; X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="375463275" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="375463275" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 08:32:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="772624342" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="772624342" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 11 Sep 2023 08:32:18 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qfitc-0006Ot-2H; Mon, 11 Sep 2023 15:32:16 +0000 Date: Mon, 11 Sep 2023 23:31:48 +0800 From: kernel test robot To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Luben Tuikov Subject: drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' Message-ID: <202309112358.oib7Qb2x-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d commit: 539f9ee4b52a8bec95ff064e22dd2fb1e258e818 drm/scheduler: properly forward fence errors date: 5 months ago config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230911/202309112358.oib7Qb2x-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230911/202309112358.oib7Qb2x-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309112358.oib7Qb2x-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' vim +266 drivers/gpu/drm/scheduler/sched_main.c 08fb97de03aa22 Andrey Grodzovsky 2022-09-30 258 71173e787cab9d Luben Tuikov 2020-12-03 259 /** 71173e787cab9d Luben Tuikov 2020-12-03 260 * drm_sched_job_done - complete a job 71173e787cab9d Luben Tuikov 2020-12-03 261 * @s_job: pointer to the job which is done 71173e787cab9d Luben Tuikov 2020-12-03 262 * 71173e787cab9d Luben Tuikov 2020-12-03 263 * Finish the job's fence and wake up the worker thread. 71173e787cab9d Luben Tuikov 2020-12-03 264 */ 539f9ee4b52a8b Christian König 2023-04-17 265 static void drm_sched_job_done(struct drm_sched_job *s_job, int result) 71173e787cab9d Luben Tuikov 2020-12-03 @266 { 71173e787cab9d Luben Tuikov 2020-12-03 267 struct drm_sched_fence *s_fence = s_job->s_fence; 71173e787cab9d Luben Tuikov 2020-12-03 268 struct drm_gpu_scheduler *sched = s_fence->sched; 71173e787cab9d Luben Tuikov 2020-12-03 269 71173e787cab9d Luben Tuikov 2020-12-03 270 atomic_dec(&sched->hw_rq_count); f2f12eb9c32bc7 Christian König 2021-02-02 271 atomic_dec(sched->score); 71173e787cab9d Luben Tuikov 2020-12-03 272 71173e787cab9d Luben Tuikov 2020-12-03 273 trace_drm_sched_process_job(s_fence); 71173e787cab9d Luben Tuikov 2020-12-03 274 71173e787cab9d Luben Tuikov 2020-12-03 275 dma_fence_get(&s_fence->finished); 539f9ee4b52a8b Christian König 2023-04-17 276 drm_sched_fence_finished(s_fence, result); 71173e787cab9d Luben Tuikov 2020-12-03 277 dma_fence_put(&s_fence->finished); 71173e787cab9d Luben Tuikov 2020-12-03 278 wake_up_interruptible(&sched->wake_up_worker); 71173e787cab9d Luben Tuikov 2020-12-03 279 } 71173e787cab9d Luben Tuikov 2020-12-03 280 :::::: The code at line 266 was first introduced by commit :::::: 71173e787cab9db4ca1fa6229477cb3d254bc285 drm/scheduler: Essentialize the job done callback :::::: TO: Luben Tuikov :::::: CC: Christian König -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki