mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jinyu Tang <tangjinyu@tinylab.org>
Cc: william.qiu@starfivetech.com, hal.feng@starfivetech.com,
	conor.dooley@microchip.com, palmer@dabbelt.com,
	apatel@ventanamicro.com, ttjjyystupid@163.com,
	falcon@tinylab.org, wangjiexun@tinylab.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] riscv: defconfig : add CONFIG_MMC_DW for starfive
Date: Tue, 12 Sep 2023 17:23:41 +0100	[thread overview]
Message-ID: <20230912-breeching-zealous-84c859e90eb7@spud> (raw)
In-Reply-To: <20230912133128.5247-1-tangjinyu@tinylab.org>

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On Tue, Sep 12, 2023 at 09:31:28PM +0800, Jinyu Tang wrote:
> If these config not set, mmc can't run for jh7110, rootfs can't
> be found when using SD card. So set CONFIG_MMC_DW=y like arm64
> defconfig, and set CONFIG_MMC_DW_STARFIVE=y for starfive. Then
> starfive vf2 board can start SD card rootfs with mainline defconfig
> and dtb.
> 
> Signed-off-by: Jinyu Tang <tangjinyu@tinylab.org>


Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> v1 -> v2:
> Change the order of these by using savedefconfig, thanks to
> Conor Dooley.
> 
>  arch/riscv/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index ab86ec3b9..76c43a532 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -169,6 +169,8 @@ CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
>  CONFIG_MMC_SDHCI_CADENCE=y
>  CONFIG_MMC_SPI=y
> +CONFIG_MMC_DW=y
> +CONFIG_MMC_DW_STARFIVE=y
>  CONFIG_MMC_SUNXI=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_SUN6I=y
> -- 
> 2.39.2
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-09-12 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 13:31 Jinyu Tang
2023-09-12 16:23 ` Conor Dooley [this message]
2023-11-06 15:00 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912-breeching-zealous-84c859e90eb7@spud \
    --to=conor@kernel.org \
    --cc=apatel@ventanamicro.com \
    --cc=conor.dooley@microchip.com \
    --cc=falcon@tinylab.org \
    --cc=hal.feng@starfivetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=tangjinyu@tinylab.org \
    --cc=ttjjyystupid@163.com \
    --cc=wangjiexun@tinylab.org \
    --cc=william.qiu@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®