From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38A3CA0EC7 for ; Mon, 11 Sep 2023 22:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377993AbjIKW3p (ORCPT ); Mon, 11 Sep 2023 18:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244150AbjIKTPM (ORCPT ); Mon, 11 Sep 2023 15:15:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D3BF9 for ; Mon, 11 Sep 2023 12:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694459707; x=1725995707; h=date:from:to:cc:subject:message-id:mime-version; bh=07/p9oDn31rTGw7P//H58/j97irnDVEbpN9U4gK1A4E=; b=mDFEbDlwazsk434avJ7H8sxUzgToh8012w0byRy7H9UHzNNXf73faDQJ mcmBP2Py1SclRmhbHKSV7yWtLvwyyLrZNTfrnUdNccOdZdbnFb03LKxo3 4KDylN4ImKI9GIVc6/qZ2CHpNjqu+ei3ve2zn+2QzIAOpAh3jSjZJpd/Z QmfO31EeolV4grWGTm3YudwlPTpl4IvlzBDzPs3EiLTghdDDTVpQ31c3y jxrlFO5LcIuySilikyhT9vgsMFgcGMwigk5JrpNrtO/VUtS0MR7uZjHDL wZ10ujYJl+q9s9d4Ivz6RrQpRmTeh+MU9wVWEUGSfGgtNobwuTUoKbxRh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="375519363" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="375519363" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 12:13:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="736875361" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="736875361" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 11 Sep 2023 12:13:34 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qfmLk-0006dm-0I; Mon, 11 Sep 2023 19:13:32 +0000 Date: Tue, 12 Sep 2023 03:12:35 +0800 From: kernel test robot To: Jens Axboe Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Oleg Nesterov Subject: kernel/task_work.c:73: warning: Function parameter or member 'data' not described in 'task_work_cancel_match' Message-ID: <202309120307.zis3yQGe-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d commit: c7aab1a7c52b82d9afd7e03c398eb03dc2aa0507 task_work: add helper for more targeted task_work canceling date: 2 years, 5 months ago config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20230912/202309120307.zis3yQGe-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309120307.zis3yQGe-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309120307.zis3yQGe-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/task_work.c:73: warning: Function parameter or member 'data' not described in 'task_work_cancel_match' vim +73 kernel/task_work.c e73f8959af0439 Oleg Nesterov 2012-05-11 60 892f6668f3a708 Oleg Nesterov 2013-09-11 61 /** c7aab1a7c52b82 Jens Axboe 2021-04-01 62 * task_work_cancel_match - cancel a pending work added by task_work_add() 892f6668f3a708 Oleg Nesterov 2013-09-11 63 * @task: the task which should execute the work c7aab1a7c52b82 Jens Axboe 2021-04-01 64 * @match: match function to call 892f6668f3a708 Oleg Nesterov 2013-09-11 65 * 892f6668f3a708 Oleg Nesterov 2013-09-11 66 * RETURNS: 892f6668f3a708 Oleg Nesterov 2013-09-11 67 * The found work or NULL if not found. 892f6668f3a708 Oleg Nesterov 2013-09-11 68 */ 67d1214551e800 Al Viro 2012-06-27 69 struct callback_head * c7aab1a7c52b82 Jens Axboe 2021-04-01 70 task_work_cancel_match(struct task_struct *task, c7aab1a7c52b82 Jens Axboe 2021-04-01 71 bool (*match)(struct callback_head *, void *data), c7aab1a7c52b82 Jens Axboe 2021-04-01 72 void *data) e73f8959af0439 Oleg Nesterov 2012-05-11 @73 { ac3d0da8f3290b Oleg Nesterov 2012-08-26 74 struct callback_head **pprev = &task->task_works; 205e550a0fb469 Oleg Nesterov 2013-09-11 75 struct callback_head *work; e73f8959af0439 Oleg Nesterov 2012-05-11 76 unsigned long flags; 61e96496d3c949 Oleg Nesterov 2016-08-02 77 61e96496d3c949 Oleg Nesterov 2016-08-02 78 if (likely(!task->task_works)) 61e96496d3c949 Oleg Nesterov 2016-08-02 79 return NULL; ac3d0da8f3290b Oleg Nesterov 2012-08-26 80 /* ac3d0da8f3290b Oleg Nesterov 2012-08-26 81 * If cmpxchg() fails we continue without updating pprev. ac3d0da8f3290b Oleg Nesterov 2012-08-26 82 * Either we raced with task_work_add() which added the ac3d0da8f3290b Oleg Nesterov 2012-08-26 83 * new entry before this work, we will find it again. Or 9da33de62431c7 Oleg Nesterov 2012-08-26 84 * we raced with task_work_run(), *pprev == NULL/exited. ac3d0da8f3290b Oleg Nesterov 2012-08-26 85 */ e73f8959af0439 Oleg Nesterov 2012-05-11 86 raw_spin_lock_irqsave(&task->pi_lock, flags); 506458efaf153c Will Deacon 2017-10-24 87 while ((work = READ_ONCE(*pprev))) { c7aab1a7c52b82 Jens Axboe 2021-04-01 88 if (!match(work, data)) ac3d0da8f3290b Oleg Nesterov 2012-08-26 89 pprev = &work->next; ac3d0da8f3290b Oleg Nesterov 2012-08-26 90 else if (cmpxchg(pprev, work, work->next) == work) 158e1645e07f3e Al Viro 2012-06-27 91 break; 158e1645e07f3e Al Viro 2012-06-27 92 } e73f8959af0439 Oleg Nesterov 2012-05-11 93 raw_spin_unlock_irqrestore(&task->pi_lock, flags); ac3d0da8f3290b Oleg Nesterov 2012-08-26 94 ac3d0da8f3290b Oleg Nesterov 2012-08-26 95 return work; e73f8959af0439 Oleg Nesterov 2012-05-11 96 } e73f8959af0439 Oleg Nesterov 2012-05-11 97 :::::: The code at line 73 was first introduced by commit :::::: e73f8959af0439d114847eab5a8a5ce48f1217c4 task_work_add: generic process-context callbacks :::::: TO: Oleg Nesterov :::::: CC: Al Viro -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki