From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 943F4CA0EC3 for ; Tue, 12 Sep 2023 04:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbjILETj (ORCPT ); Tue, 12 Sep 2023 00:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbjILETf (ORCPT ); Tue, 12 Sep 2023 00:19:35 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C53CD1BE for ; Mon, 11 Sep 2023 21:19:30 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d78452de9cbso4816975276.2 for ; Mon, 11 Sep 2023 21:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694492369; x=1695097169; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=8bQIDDMeJOvnkHBSHpviPM53nQLzWxLl8V8lczrc7P4=; b=vcnTIcnQs09CNgXh4Yr6/iN9kRK7a4j413YEvYescMwBWS9B3hAvMO+CFtRe4v+9l2 z7WqqwAV+bvOU96/UrJUHerBWEEGwU4BpFON14UL1cpNe48hpa9I/0wVa+VKamDTpqW7 M8dAakBs4mbXcSniTkb+WzxqfH6jMVMRzui2umdP2I27/CGN9LWM80eY1wSRkPXo507N YxlTv2J+jMS6XbSMBDv/aESh9Ch6PAqC8RBhBT/IxHPDvDk7AiEMzZLspa+KSQI4aPSx G+rkcJgANtRBeCu4mYPSP2vmXo3xnK4Q5MIxnsYFUpSRZQsqMEF3er9vK1XtbXECEhbx p3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694492369; x=1695097169; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8bQIDDMeJOvnkHBSHpviPM53nQLzWxLl8V8lczrc7P4=; b=Xx/jcACaN5RYSZDOrTXYlhxfxMhgkFVGcR4fSjsvCA0MVvkZBqKR2SsqO3wkXWZtc+ wmuuGycSzrdwfxKWtk6NiOSHtA5PW53VXFnGemkHwjJ4bB4mVbG/bAafLJ9UmOXsUMEc Gi/MKRJ4Hh02P1B/xl4micJppTEghdM8DSddqMDMB5BRrc7hL9kIVzQY7p3+SE/50mTp kf116DeucEuLMKVkHuY5aFmY9j1PRc48cEFywHPfGw1pbxi4+48TAPHMciWP1jLORdjq iO6CmtqvngeUVRCE849vU/2gYYRaB+i5cQd3fiKk0KjpVe/WNK4DNxJlrh9GoiRzNdZj 0GVg== X-Gm-Message-State: AOJu0YwZxtW63G6DrmoxNmMTpDkjd4pccX2BeuHni6Hy6VqxTowj68Hs t/Ey3iHnou0yr9mLvI6IOIzJbbR8uJUQ X-Google-Smtp-Source: AGHT+IH5Q6+ZU2OyNHaxHNWOUFrqc2SVY3WLdBjlE5/6CVJSmUp9U2Mk6zQFcS1q8cYySIWsvuEbsGlM3/R7 X-Received: from hi-h2o-specialist.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3cef]) (user=arakesh job=sendgmr) by 2002:a5b:1cb:0:b0:d77:ff06:b58b with SMTP id f11-20020a5b01cb000000b00d77ff06b58bmr258526ybp.10.1694492369636; Mon, 11 Sep 2023 21:19:29 -0700 (PDT) Date: Mon, 11 Sep 2023 21:19:08 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog Message-ID: <20230912041910.726442-1-arakesh@google.com> Subject: [PATCH v1 0/2] usb: gadget: uvc: stability fixes when stopping streams From: Avichal Rakesh To: Laurent Pinchart , Daniel Scally , Greg Kroah-Hartman , Michael Grzeschik Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Avichal Rakesh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have been seeing two main bugs when stopping stream: 1. attempting to queue usb_requests on a disabled usb endpoint, and 2. use-after-free problems for inflight requests Avichal Rakesh (2): usb: gadget: uvc: prevent use of disabled endpoint usb: gadget: uvc: prevent de-allocating inflight usb_requests drivers/usb/gadget/function/f_uvc.c | 11 ++++---- drivers/usb/gadget/function/f_uvc.h | 2 +- drivers/usb/gadget/function/uvc.h | 5 +++- drivers/usb/gadget/function/uvc_v4l2.c | 21 ++++++++++++--- drivers/usb/gadget/function/uvc_video.c | 34 +++++++++++++++++++++++-- 5 files changed, 60 insertions(+), 13 deletions(-) -- 2.42.0.283.g2d96d420d3-goog