From: "Adrián Larumbe" <adrian.larumbe@collabora.com>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run,
marijn.suijten@somainline.org, robh@kernel.org,
steven.price@arm.com
Cc: adrian.larumbe@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, healych@amazon.com,
kernel@collabora.com
Subject: [PATCH v4 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats
Date: Tue, 12 Sep 2023 09:37:00 +0100 [thread overview]
Message-ID: <20230912084044.955864-7-adrian.larumbe@collabora.com> (raw)
In-Reply-To: <20230912084044.955864-1-adrian.larumbe@collabora.com>
The current implementation will try to pick the highest available size
display unit as soon as the BO size exceeds that of the previous
multiplier. That can lead to loss of precision in BO's whose size is
not a multiple of a MiB.
Fix it by changing the unit selection criteria.
For much bigger BO's, their size will naturally be aligned on something
bigger than a 4 KiB page, so in practice it is very unlikely their display
unit would default to KiB.
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 762965e3d503..bf7d2fe46bfa 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -879,7 +879,7 @@ static void print_size(struct drm_printer *p, const char *stat,
unsigned u;
for (u = 0; u < ARRAY_SIZE(units) - 1; u++) {
- if (sz < SZ_1K)
+ if (sz & (SZ_1K - 1))
break;
sz = div_u64(sz, SZ_1K);
}
--
2.42.0
next prev parent reply other threads:[~2023-09-12 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 8:36 [PATCH v4 0/6] Add fdinfo support to Panfrost Adrián Larumbe
2023-09-12 8:36 ` [PATCH v4 1/6] drm/panfrost: Add cycle count GPU register definitions Adrián Larumbe
2023-09-12 8:36 ` [PATCH v4 2/6] drm/panfrost: Add fdinfo support GPU load metrics Adrián Larumbe
2023-09-12 9:28 ` Boris Brezillon
2023-09-12 8:36 ` [PATCH v4 3/6] drm/panfrost: Add fdinfo support for memory stats Adrián Larumbe
2023-09-12 9:29 ` Boris Brezillon
2023-09-12 8:36 ` [PATCH v4 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo Adrián Larumbe
2023-09-12 8:36 ` [PATCH v4 5/6] drm/panfrost: Implement generic DRM object RSS reporting function Adrián Larumbe
2023-09-12 9:29 ` Boris Brezillon
2023-09-12 8:37 ` Adrián Larumbe [this message]
2023-09-12 9:32 ` [PATCH v4 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats Boris Brezillon
2023-09-13 1:46 ` Rob Clark
2023-09-13 2:14 ` Rob Clark
2023-09-13 7:36 ` Boris Brezillon
2023-09-13 16:46 ` Rob Clark
2023-09-13 17:17 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912084044.955864-7-adrian.larumbe@collabora.com \
--to=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=healych@amazon.com \
--cc=kernel@collabora.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®