mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dragos Tatulea <dtatulea@nvidia.com>
To: "Jason Wang" <jasowang@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Si-Wei Liu" <si-wei.liu@oracle.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Saeed Mahameed" <saeedm@nvidia.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: Dragos Tatulea <dtatulea@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>, <kvm@vger.kernel.org>
Subject: [PATCH 07/16] vdpa/mlx5: Collapse "dvq" mr add/delete functions
Date: Tue, 12 Sep 2023 16:01:17 +0300	[thread overview]
Message-ID: <20230912130132.561193-8-dtatulea@nvidia.com> (raw)
In-Reply-To: <20230912130132.561193-1-dtatulea@nvidia.com>

Now that the cvq code is out of mlx5_vdpa_create/destroy_mr, the "dvq"
functions can be folded into their callers.

Having "dvq" in the naming will no longer be accurate in the downstream
patches.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 drivers/vdpa/mlx5/core/mr.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/vdpa/mlx5/core/mr.c b/drivers/vdpa/mlx5/core/mr.c
index 587300e7c18e..fde00497f4ad 100644
--- a/drivers/vdpa/mlx5/core/mr.c
+++ b/drivers/vdpa/mlx5/core/mr.c
@@ -489,7 +489,7 @@ static void destroy_user_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_mr *mr
 	}
 }
 
-static void _mlx5_vdpa_destroy_dvq_mr(struct mlx5_vdpa_dev *mvdev, unsigned int asid)
+static void _mlx5_vdpa_destroy_mr(struct mlx5_vdpa_dev *mvdev, unsigned int asid)
 {
 	struct mlx5_vdpa_mr *mr = &mvdev->mr;
 
@@ -513,7 +513,7 @@ void mlx5_vdpa_destroy_mr_asid(struct mlx5_vdpa_dev *mvdev, unsigned int asid)
 
 	mutex_lock(&mr->mkey_mtx);
 
-	_mlx5_vdpa_destroy_dvq_mr(mvdev, asid);
+	_mlx5_vdpa_destroy_mr(mvdev, asid);
 
 	mutex_unlock(&mr->mkey_mtx);
 }
@@ -524,9 +524,9 @@ void mlx5_vdpa_destroy_mr(struct mlx5_vdpa_dev *mvdev)
 	prune_iotlb(mvdev);
 }
 
-static int _mlx5_vdpa_create_dvq_mr(struct mlx5_vdpa_dev *mvdev,
-				    struct vhost_iotlb *iotlb,
-				    unsigned int asid)
+static int _mlx5_vdpa_create_mr(struct mlx5_vdpa_dev *mvdev,
+				struct vhost_iotlb *iotlb,
+				unsigned int asid)
 {
 	struct mlx5_vdpa_mr *mr = &mvdev->mr;
 	int err;
@@ -550,12 +550,6 @@ static int _mlx5_vdpa_create_dvq_mr(struct mlx5_vdpa_dev *mvdev,
 	return 0;
 }
 
-static int _mlx5_vdpa_create_mr(struct mlx5_vdpa_dev *mvdev,
-				struct vhost_iotlb *iotlb, unsigned int asid)
-{
-	return _mlx5_vdpa_create_dvq_mr(mvdev, iotlb, asid);
-}
-
 int mlx5_vdpa_create_mr(struct mlx5_vdpa_dev *mvdev, struct vhost_iotlb *iotlb,
 			unsigned int asid)
 {
-- 
2.41.0


  parent reply	other threads:[~2023-09-12 13:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 13:01 [PATCH 00/16] vdpa: Add support for vq descriptor mappings Dragos Tatulea
2023-09-12 13:01 ` [PATCH 01/16] vdpa: introduce dedicated descriptor group for virtqueue Dragos Tatulea
2023-09-12 13:01 ` [PATCH 02/16] vhost-vdpa: introduce descriptor group backend feature Dragos Tatulea
2023-09-12 13:01 ` [PATCH 03/16] vhost-vdpa: uAPI to get dedicated descriptor group id Dragos Tatulea
2023-09-12 13:01 ` [PATCH 04/16] vdpa/mlx5: Create helper function for dma mappings Dragos Tatulea
2023-09-26  3:11   ` Jason Wang
2023-09-12 13:01 ` [PATCH 05/16] vdpa/mlx5: Decouple cvq iotlb handling from hw mapping code Dragos Tatulea
2023-09-26  3:28   ` Jason Wang
2023-09-12 13:01 ` [PATCH 06/16] vdpa/mlx5: Take cvq iotlb lock during refresh Dragos Tatulea
2023-09-26  3:33   ` Jason Wang
2023-09-12 13:01 ` Dragos Tatulea [this message]
2023-09-26  3:33   ` [PATCH 07/16] vdpa/mlx5: Collapse "dvq" mr add/delete functions Jason Wang
2023-09-12 13:01 ` [PATCH 08/16] vdpa/mlx5: Rename mr destroy functions Dragos Tatulea
2023-09-26  3:34   ` Jason Wang
2023-09-12 13:01 ` [PATCH 09/16] vdpa/mlx5: Allow creation/deletion of any given mr struct Dragos Tatulea
2023-09-26  4:44   ` Jason Wang
2023-09-26  7:21     ` Dragos Tatulea
2023-10-08  4:25       ` Jason Wang
2023-10-08 12:04         ` Dragos Tatulea
2023-10-09  6:39           ` Jason Wang
2023-10-09  7:06             ` Dragos Tatulea
2023-09-12 13:01 ` [PATCH 10/16] vdpa/mlx5: Move mr mutex out of " Dragos Tatulea
2023-09-12 13:01 ` [PATCH 11/16] vdpa/mlx5: Improve mr update flow Dragos Tatulea
2023-09-12 13:01 ` [PATCH 12/16] vdpa/mlx5: Introduce mr for vq descriptor Dragos Tatulea
2023-09-12 13:01 ` [PATCH 13/16] vdpa/mlx5: Enable hw support for vq descriptor mapping Dragos Tatulea
2023-09-12 13:01 ` [PATCH 14/16] vdpa/mlx5: Make iotlb helper functions more generic Dragos Tatulea
2023-09-12 13:01 ` [PATCH 15/16] vdpa/mlx5: Update cvq iotlb mapping on ASID change Dragos Tatulea
2023-09-13  1:03 ` [PATCH 00/16] vdpa: Add support for vq descriptor mappings Lei Yang
2023-09-13 16:08   ` Eugenio Perez Martin
2023-09-15  6:34     ` Si-Wei Liu
2023-09-20  1:14       ` Lei Yang
2023-09-25  7:59 ` Dragos Tatulea
2023-09-26 12:22   ` Si-Wei Liu
2023-09-26 12:37     ` Dragos Tatulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912130132.561193-8-dtatulea@nvidia.com \
    --to=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®