From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] overlayfs: set ctime when setting mtime and atime
Date: Wed, 13 Sep 2023 18:45:02 +0200 [thread overview]
Message-ID: <20230913-hausbank-wortlaut-b2bb3cee6156@brauner> (raw)
In-Reply-To: <20230913-ctime-v1-1-c6bc509cbc27@kernel.org>
On Wed, Sep 13, 2023 at 09:33:12AM -0400, Jeff Layton wrote:
> Nathan reported that he was seeing the new warning in
> setattr_copy_mgtime pop when starting podman containers. Overlayfs is
> trying to set the atime and mtime via notify_change without also
> setting the ctime.
>
> POSIX states that when the atime and mtime are updated via utimes() that
> we must also update the ctime to the current time. The situation with
> overlayfs copy-up is analogies, so add ATTR_CTIME to the bitmask.
> notify_change will fill in the value.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
Looks good to me,
Acked-by: Christian Brauner <brauner@kernel.org>
So we can wait for ovl to upstream this fix next and then we'll delay
sending the ctime fixes or we'll take this fixup as well. Just let me
know what you all prefer.
next prev parent reply other threads:[~2023-09-13 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 13:33 Jeff Layton
2023-09-13 13:35 ` Jeff Layton
2023-09-13 16:45 ` Christian Brauner [this message]
2023-09-13 17:04 ` Jeff Layton
2023-09-13 17:36 ` Amir Goldstein
2023-09-14 10:27 ` Jeff Layton
2023-09-13 19:57 ` Nathan Chancellor
2023-09-14 8:39 ` Christian Brauner
2023-09-22 13:52 ` Jeff Layton
2023-09-23 9:32 ` Amir Goldstein
2023-09-25 12:51 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913-hausbank-wortlaut-b2bb3cee6156@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nathan@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®