From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06703CA5501 for ; Wed, 13 Sep 2023 07:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238547AbjIMHRS (ORCPT ); Wed, 13 Sep 2023 03:17:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236080AbjIMHRR (ORCPT ); Wed, 13 Sep 2023 03:17:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 513F51729 for ; Wed, 13 Sep 2023 00:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694589433; x=1726125433; h=date:from:to:cc:subject:message-id:mime-version; bh=CzMnrLw6Aoblyhf/wdNHkvTJ1620mcG6vnS2RsgkEWg=; b=AiincBO096rQXETNTFlRACDDctOmZ5tNryqhUDSsr+9sfNiFYOh6+yAO oDElly9zF5OxH16c+wfi27Ptu0wQrYz+7cizhnpzMUHuNnqooqxla0hxX HWsK78iCn4VxAV3RUTmOJCdbLETHYCfvC9fEsVxVq925uuR5shBhkzJxV b5Hs6uctZd3Tm4Lli5pkv8UZVViHqfry7ydQmMhv4NfR01qeUn7rcJtzC YRzkrD3cFJ3101S6S83L+u8O0CiluJ0EU8tiJ12l4s3TQSLDIBPqSI/se KNwSaeY5Y5yYT/CstvR5D6b2PISem8dGVkQTrRkoKJTD77q+Kypq6W5ux w==; X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="377496850" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="377496850" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 00:16:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="693758670" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="693758670" Received: from lkp-server02.sh.intel.com (HELO cf13c67269a2) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 13 Sep 2023 00:16:54 -0700 Received: from kbuild by cf13c67269a2 with local (Exim 4.96) (envelope-from ) id 1qgK5L-0000Bp-31; Wed, 13 Sep 2023 07:15:16 +0000 Date: Wed, 13 Sep 2023 15:14:49 +0800 From: kernel test robot To: Tom Rix Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Ellerman , Christophe Leroy Subject: arch/powerpc/platforms/cell/spu_base.c:229: warning: Function parameter or member 'slbs' not described in '__slb_present' Message-ID: <202309131549.VzC1pNwr-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3669558bdf354cd352be955ef2764cde6a9bf5ec commit: da5311a4b852eaf2c0feac8b28884a8d8a801dfc powerpc/spufs: remove unneeded if-checks date: 4 months ago config: powerpc-ppc64_defconfig (https://download.01.org/0day-ci/archive/20230913/202309131549.VzC1pNwr-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309131549.VzC1pNwr-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309131549.VzC1pNwr-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/powerpc/platforms/cell/spu_base.c:229: warning: Function parameter or member 'slbs' not described in '__slb_present' >> arch/powerpc/platforms/cell/spu_base.c:229: warning: Function parameter or member 'nr_slbs' not described in '__slb_present' >> arch/powerpc/platforms/cell/spu_base.c:229: warning: Function parameter or member 'new_addr' not described in '__slb_present' >> arch/powerpc/platforms/cell/spu_base.c:229: warning: expecting prototype for Given an array of @nr_slbs SLB entries, @slbs, return non(). Prototype was for __slb_present() instead >> arch/powerpc/platforms/cell/spu_base.c:241: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Setup the SPU kernel SLBs, in preparation for a context save/restore. We vim +229 arch/powerpc/platforms/cell/spu_base.c 58bd403c3c79dd Jeremy Kerr 2007-12-05 222 684bd614015188 Jeremy Kerr 2007-12-05 223 /** 684bd614015188 Jeremy Kerr 2007-12-05 224 * Given an array of @nr_slbs SLB entries, @slbs, return non-zero if the 684bd614015188 Jeremy Kerr 2007-12-05 225 * address @new_addr is present. 684bd614015188 Jeremy Kerr 2007-12-05 226 */ 73d16a6e0e5199 Ian Munsie 2014-10-08 227 static inline int __slb_present(struct copro_slb *slbs, int nr_slbs, 684bd614015188 Jeremy Kerr 2007-12-05 228 void *new_addr) 684bd614015188 Jeremy Kerr 2007-12-05 @229 { 684bd614015188 Jeremy Kerr 2007-12-05 230 unsigned long ea = (unsigned long)new_addr; 684bd614015188 Jeremy Kerr 2007-12-05 231 int i; 684bd614015188 Jeremy Kerr 2007-12-05 232 684bd614015188 Jeremy Kerr 2007-12-05 233 for (i = 0; i < nr_slbs; i++) 684bd614015188 Jeremy Kerr 2007-12-05 234 if (!((slbs[i].esid ^ ea) & ESID_MASK)) 684bd614015188 Jeremy Kerr 2007-12-05 235 return 1; 684bd614015188 Jeremy Kerr 2007-12-05 236 684bd614015188 Jeremy Kerr 2007-12-05 237 return 0; 684bd614015188 Jeremy Kerr 2007-12-05 238 } 684bd614015188 Jeremy Kerr 2007-12-05 239 58bd403c3c79dd Jeremy Kerr 2007-12-05 240 /** 58bd403c3c79dd Jeremy Kerr 2007-12-05 @241 * Setup the SPU kernel SLBs, in preparation for a context save/restore. We 58bd403c3c79dd Jeremy Kerr 2007-12-05 242 * need to map both the context save area, and the save/restore code. 684bd614015188 Jeremy Kerr 2007-12-05 243 * 027dfac694fc27 Michael Ellerman 2016-06-01 244 * Because the lscsa and code may cross segment boundaries, we check to see 684bd614015188 Jeremy Kerr 2007-12-05 245 * if mappings are required for the start and end of each range. We currently 684bd614015188 Jeremy Kerr 2007-12-05 246 * assume that the mappings are smaller that one segment - if not, something 684bd614015188 Jeremy Kerr 2007-12-05 247 * is seriously wrong. 58bd403c3c79dd Jeremy Kerr 2007-12-05 248 */ 684bd614015188 Jeremy Kerr 2007-12-05 249 void spu_setup_kernel_slbs(struct spu *spu, struct spu_lscsa *lscsa, 684bd614015188 Jeremy Kerr 2007-12-05 250 void *code, int code_size) 58bd403c3c79dd Jeremy Kerr 2007-12-05 251 { 73d16a6e0e5199 Ian Munsie 2014-10-08 252 struct copro_slb slbs[4]; 684bd614015188 Jeremy Kerr 2007-12-05 253 int i, nr_slbs = 0; 684bd614015188 Jeremy Kerr 2007-12-05 254 /* start and end addresses of both mappings */ 684bd614015188 Jeremy Kerr 2007-12-05 255 void *addrs[] = { 684bd614015188 Jeremy Kerr 2007-12-05 256 lscsa, (void *)lscsa + sizeof(*lscsa) - 1, 684bd614015188 Jeremy Kerr 2007-12-05 257 code, code + code_size - 1 684bd614015188 Jeremy Kerr 2007-12-05 258 }; 684bd614015188 Jeremy Kerr 2007-12-05 259 684bd614015188 Jeremy Kerr 2007-12-05 260 /* check the set of addresses, and create a new entry in the slbs array 684bd614015188 Jeremy Kerr 2007-12-05 261 * if there isn't already a SLB for that address */ 684bd614015188 Jeremy Kerr 2007-12-05 262 for (i = 0; i < ARRAY_SIZE(addrs); i++) { 684bd614015188 Jeremy Kerr 2007-12-05 263 if (__slb_present(slbs, nr_slbs, addrs[i])) 684bd614015188 Jeremy Kerr 2007-12-05 264 continue; 58bd403c3c79dd Jeremy Kerr 2007-12-05 265 684bd614015188 Jeremy Kerr 2007-12-05 266 __spu_kernel_slb(addrs[i], &slbs[nr_slbs]); 684bd614015188 Jeremy Kerr 2007-12-05 267 nr_slbs++; 684bd614015188 Jeremy Kerr 2007-12-05 268 } 58bd403c3c79dd Jeremy Kerr 2007-12-05 269 c92a1acb675058 Arnd Bergmann 2008-02-28 270 spin_lock_irq(&spu->register_lock); 684bd614015188 Jeremy Kerr 2007-12-05 271 /* Add the set of SLBs */ 684bd614015188 Jeremy Kerr 2007-12-05 272 for (i = 0; i < nr_slbs; i++) 684bd614015188 Jeremy Kerr 2007-12-05 273 spu_load_slb(spu, i, &slbs[i]); c92a1acb675058 Arnd Bergmann 2008-02-28 274 spin_unlock_irq(&spu->register_lock); 58bd403c3c79dd Jeremy Kerr 2007-12-05 275 } 58bd403c3c79dd Jeremy Kerr 2007-12-05 276 EXPORT_SYMBOL_GPL(spu_setup_kernel_slbs); 58bd403c3c79dd Jeremy Kerr 2007-12-05 277 :::::: The code at line 229 was first introduced by commit :::::: 684bd614015188561197342fd336292e9e2ce196 [POWERPC] cell: handle SPE kernel mappings that cross segment boundaries :::::: TO: Jeremy Kerr :::::: CC: Arnd Bergmann -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki