From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Myunguk Kim <mwkim@gaonchips.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
fido_max@inbox.ru, kuninori.morimoto.gx@renesas.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
perex@perex.cz, tiwai@suse.com, xingyu.wu@starfivetech.com
Subject: Re: [PATCH] [v2] ASoC: dwc: fix typo in comment
Date: Thu, 14 Sep 2023 08:32:48 +0200 [thread overview]
Message-ID: <20230914063248.rquitqthmddgm5oa@pengutronix.de> (raw)
In-Reply-To: <20230914005633.2423696-1-mwkim@gaonchips.com>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Thu, Sep 14, 2023 at 09:56:34AM +0900, Myunguk Kim wrote:
> > The patch is obviously corrupted, the { there should be on the prior
> > line and even fixing that by hand there appear to be some other issues.
>
> The patch file should have been attached as shown below.
> Is there a problem with my git send-email?
>
> ---
> sound/soc/dwc/dwc-i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
> irq_valid = true;
> }
>
> - /* Error Handling: TX */
> + /* Error Handling: RX */
> if (isr[i] & ISR_RXFO)
> { dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
> irq_valid = true;
FTR: I get this mail directly (so no mailing list server involved), and
the patch is mangled in the same way as broonie pointed out in his mail
earlier in this thread.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-14 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 2:41 Myunguk Kim
2023-09-13 7:27 ` Bagas Sanjaya
2023-09-13 17:52 ` Mark Brown
2023-09-14 0:56 ` Myunguk Kim
2023-09-14 6:32 ` Uwe Kleine-König [this message]
2023-09-14 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914063248.rquitqthmddgm5oa@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fido_max@inbox.ru \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwkim@gaonchips.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®