mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Durrant <paul@xen.org>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Paul Durrant <pdurrant@amazon.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 4/8] KVM: pfncache: base offset check on khva rather than gpa
Date: Thu, 14 Sep 2023 08:49:42 +0000	[thread overview]
Message-ID: <20230914084946.200043-5-paul@xen.org> (raw)
In-Reply-To: <20230914084946.200043-1-paul@xen.org>

From: Paul Durrant <pdurrant@amazon.com>

After a subsequent patch, the gpa may not always be set whereas khva will
(as long as the cache valid flag is also set).

Signed-off-by: Paul Durrant <pdurrant@amazon.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>
---
 virt/kvm/pfncache.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/pfncache.c b/virt/kvm/pfncache.c
index 17afbb464a70..37bcb4399780 100644
--- a/virt/kvm/pfncache.c
+++ b/virt/kvm/pfncache.c
@@ -83,15 +83,18 @@ bool kvm_gpc_check(struct gfn_to_pfn_cache *gpc, unsigned long len)
 	if (!gpc->active)
 		return false;
 
-	if ((gpc->gpa & ~PAGE_MASK) + len > PAGE_SIZE)
+	if (gpc->generation != slots->generation)
 		return false;
 
-	if (gpc->generation != slots->generation || kvm_is_error_hva(gpc->uhva))
+	if (kvm_is_error_hva(gpc->uhva))
 		return false;
 
 	if (!gpc->valid)
 		return false;
 
+	if (offset_in_page(gpc->khva) + len > PAGE_SIZE)
+		return false;
+
 	return true;
 }
 EXPORT_SYMBOL_GPL(kvm_gpc_check);
-- 
2.39.2


  parent reply	other threads:[~2023-09-14  9:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  8:49 [PATCH 0/8] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-09-14  8:49 ` [PATCH 1/8] KVM: pfncache: add a map helper function Paul Durrant
2023-09-14  9:17   ` David Woodhouse
2023-09-14  8:49 ` [PATCH 2/8] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-09-14  9:21   ` David Woodhouse
2023-09-14  9:34     ` Paul Durrant
2023-09-14 12:39       ` David Woodhouse
2023-09-14 13:07         ` Paul Durrant
2023-09-14  8:49 ` [PATCH 3/8] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-09-14 13:03   ` David Woodhouse
2023-09-14  8:49 ` Paul Durrant [this message]
2023-09-14 12:42   ` [PATCH 4/8] KVM: pfncache: base offset check on khva rather than gpa David Woodhouse
2023-09-14  8:49 ` [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-09-14  9:29   ` David Woodhouse
2023-09-14  9:38     ` Paul Durrant
2023-09-14 13:51   ` David Woodhouse
2023-09-14 13:58     ` Paul Durrant
2023-09-14  8:49 ` [PATCH 6/8] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-09-14 13:43   ` David Woodhouse
2023-09-14  8:49 ` [PATCH 7/8] KVM: xen: prepare for using 'default' vcpu_info Paul Durrant
2023-09-14 13:17   ` David Woodhouse
2023-09-14 20:10   ` kernel test robot
2023-09-18  9:25   ` kernel test robot
2023-09-14  8:49 ` [PATCH 8/8] KVM: xen: automatically use the vcpu_info embedded in shared_info Paul Durrant
2023-09-14  9:09   ` David Woodhouse
2023-09-14  9:17     ` Paul Durrant
2023-09-14  9:24       ` David Woodhouse
2023-09-14  9:15 ` [PATCH 0/8] KVM: xen: update shared_info and vcpu_info handling David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230914084946.200043-5-paul@xen.org \
    --to=paul@xen.org \
    --cc=dwmw2@infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=pdurrant@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®