From: Qais Yousef <qyousef@layalina.io>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
Wei Wang <wvw@google.com>, Xuewen Yan <xuewen.yan94@gmail.com>,
Hank <han.lin@mediatek.com>,
Jonathan JMChen <Jonathan.JMChen@mediatek.com>,
Hongyan Xia <hongyan.xia2@arm.com>
Subject: Re: [PATCH v4 1/3] sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0
Date: Sat, 16 Sep 2023 20:27:09 +0100 [thread overview]
Message-ID: <20230916192709.5s22femf73pccmu3@airbuntu> (raw)
In-Reply-To: <ZQKqsL0MCZCW3Rpi@gmail.com>
On 09/14/23 08:39, Ingo Molnar wrote:
>
> * Qais Yousef <qyousef@layalina.io> wrote:
>
> > > Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> >
> > Thanks for the review!
> >
> > I will wait for the maintainers to see if they would like a v5 to address
> > the nitpicks or it's actually good enough and happy to pick this up. I
> > think the commit messages explain the problem clear enough and doesn't
> > warrant sending a new version. But happy to do so if there's insistence
> > :-)
>
> Yeah, please always do that: sensible review replies with actionable
> feedback cause a semi-atomatic "mark this thread as read, there will be a
> next version" reflexive action from maintainers, especially if a series is
> in its 4th iteration already...
Apologies. I did realize that and intended to send a new version last weekend,
but failed to get to it. I hope to be able to do so today or tomorrow.
Thanks!
--
Qais Yousef
next prev parent reply other threads:[~2023-09-16 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 22:45 [PATCH v4 0/3] Fix a couple of corner cases in feec() when using uclamp_max Qais Yousef
2023-08-21 22:45 ` [PATCH v4 1/3] sched/uclamp: Set max_spare_cap_cpu even if max_spare_cap is 0 Qais Yousef
2023-08-23 10:30 ` Dietmar Eggemann
2023-08-26 20:41 ` Qais Yousef
2023-09-14 6:39 ` Ingo Molnar
2023-09-16 19:27 ` Qais Yousef [this message]
2023-08-21 22:45 ` [PATCH v4 2/3] sched/uclamp: Ignore (util == 0) optimization in feec() when p_util_max = 0 Qais Yousef
2023-08-23 10:30 ` Dietmar Eggemann
2023-08-21 22:45 ` [PATCH v4 3/3] sched/tp: Add new tracepoint to track compute energy computation Qais Yousef
2023-08-23 10:30 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916192709.5s22femf73pccmu3@airbuntu \
--to=qyousef@layalina.io \
--cc=Jonathan.JMChen@mediatek.com \
--cc=dietmar.eggemann@arm.com \
--cc=han.lin@mediatek.com \
--cc=hongyan.xia2@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®