From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D48CD13D1 for ; Sun, 17 Sep 2023 03:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232452AbjIQDAZ (ORCPT ); Sat, 16 Sep 2023 23:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjIQDAG (ORCPT ); Sat, 16 Sep 2023 23:00:06 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 19917CDC; Sat, 16 Sep 2023 19:59:59 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 38H2xjpm009886; Sun, 17 Sep 2023 04:59:45 +0200 Date: Sun, 17 Sep 2023 04:59:45 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 3/4] tools/nolibc: don't define new syscall number Message-ID: <20230917025945.GF9646@1wt.eu> References: <20230914-nolibc-syscall-nr-v1-0-e50df410da11@weissschuh.net> <20230914-nolibc-syscall-nr-v1-3-e50df410da11@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230914-nolibc-syscall-nr-v1-3-e50df410da11@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2023 at 06:01:19PM +0200, Thomas Weißschuh wrote: > All symbols created by nolibc are also visible to user code. > Syscall constants are expected to come from the kernel headers and > should not be made up by nolibc. > > Refactor the logic to avoid defining syscall numbers. > Also the new code is easier to understand. > > Signed-off-by: Thomas Weißschuh Yeah that's a good point! Acked-by: Willy Tarreau Willy