From: Hsiao Chien Sung <shawn.sung@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
Chen-Yu Tsai <wenst@chromium.org>, CK Hu <ck.hu@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Hsiao Chien Sung <shawn.sung@mediatek.com>
Subject: [PATCH v2 06/11] drm/mediatek: Support alpha blending in display driver
Date: Mon, 18 Sep 2023 16:42:02 +0800 [thread overview]
Message-ID: <20230918084207.23604-7-shawn.sung@mediatek.com> (raw)
In-Reply-To: <20230918084207.23604-1-shawn.sung@mediatek.com>
Support alpha blending by adding correct blend mode and
alpha property in plane initialization.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index db2f70ae060d..f87cf56fb846 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -301,6 +301,9 @@ int mtk_plane_init(struct drm_device *dev, struct drm_plane *plane,
size_t num_formats)
{
int err;
+ u32 blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+ BIT(DRM_MODE_BLEND_PREMULTI) |
+ BIT(DRM_MODE_BLEND_COVERAGE);
if (!formats || !num_formats) {
DRM_ERROR("no formats for plane\n");
@@ -323,6 +326,14 @@ int mtk_plane_init(struct drm_device *dev, struct drm_plane *plane,
DRM_INFO("Create rotation property failed\n");
}
+ err = drm_plane_create_alpha_property(plane);
+ if (err)
+ DRM_ERROR("failed to create property: alpha\n");
+
+ err = drm_plane_create_blend_mode_property(plane, blend_mode);
+ if (err)
+ DRM_ERROR("failed to create property: blend_mode\n");
+
drm_plane_helper_add(plane, &mtk_plane_helper_funcs);
return 0;
--
2.18.0
next prev parent reply other threads:[~2023-09-18 8:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:41 [PATCH v2 00/11] Support IGT " Hsiao Chien Sung
2023-09-18 8:41 ` [PATCH v2 01/11] soc: mediatek: Add register definitions for GCE Hsiao Chien Sung
2023-09-18 9:06 ` AngeloGioacchino Del Regno
2023-09-18 8:41 ` [PATCH v2 02/11] soc: mediatek: Support GCE jump to absolute Hsiao Chien Sung
2023-09-18 8:51 ` CK Hu (胡俊光)
2023-09-18 8:41 ` [PATCH v2 03/11] soc: mediatek: Disable 9-bit alpha in ETHDR Hsiao Chien Sung
2023-09-18 9:06 ` AngeloGioacchino Del Regno
2023-09-18 8:42 ` [PATCH v2 04/11] drm/mediatek: Add OVL compatible name for MT8195 Hsiao Chien Sung
2023-09-18 9:09 ` CK Hu (胡俊光)
2023-09-18 9:21 ` AngeloGioacchino Del Regno
2023-09-18 9:27 ` CK Hu (胡俊光)
2023-10-11 9:38 ` Shawn Sung (宋孝謙)
2023-10-11 11:51 ` AngeloGioacchino Del Regno
2023-10-12 2:18 ` Shawn Sung (宋孝謙)
2023-09-18 8:42 ` [PATCH v2 05/11] drm/mediatek: Adjust DRM mode configs for IGT Hsiao Chien Sung
2023-09-18 9:05 ` CK Hu (胡俊光)
2023-09-18 8:42 ` Hsiao Chien Sung [this message]
2023-09-18 9:25 ` [PATCH v2 06/11] drm/mediatek: Support alpha blending in display driver CK Hu (胡俊光)
2023-09-18 8:42 ` [PATCH v2 07/11] drm/mediatek: Support alpha blending in VDOSYS0 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 08/11] drm/mediatek: Support alpha blending in VDOSYS1 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 09/11] drm/mediatek: Support CRC in display driver Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 10/11] drm/mediatek: Support CRC in VDOSYS0 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 11/11] drm/mediatek: Support CRC in VDOSYS1 Hsiao Chien Sung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918084207.23604-7-shawn.sung@mediatek.com \
--to=shawn.sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®