From: Sudeep Holla <sudeep.holla@arm.com>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: rafael@kernel.org, rafael.j.wysocki@intel.com,
Sudeep Holla <sudeep.holla@arm.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
liuyonglong@huawei.com
Subject: Re: [PATCH] mailbox: pcc: export the PCC subspace type
Date: Mon, 18 Sep 2023 09:43:55 +0100 [thread overview]
Message-ID: <20230918084355.rzh7k6y7uuaitanj@bogus> (raw)
In-Reply-To: <5ec151a4-5e2c-7745-c8ef-1edc5e7ef157@huawei.com>
On Fri, Sep 15, 2023 at 03:04:57PM +0800, lihuisong (C) wrote:
>
> 在 2023/9/15 0:13, Sudeep Holla 写道:
> > On Thu, Sep 14, 2023 at 07:57:53PM +0800, Huisong Li wrote:
> > > As stated in APCI spec, the size of the subspace shared memory region may
> > > be different for different types. So it is useful for driver to fill PCC
> > > communication space. But the driver used this PCC channel doesn't know what
> > > is the subspace type of the channel.
> > >
> > > So export the PCC subspace type by requesting PCC channel.
> > >
> > I would prefer to avoid this, but please post it with user to get better
> > understanding of it.
> Hi Sudeep,
>
> Thanks for your fast review.
> Sorry, I cannot fully understand what you mean. What should I do for it?
> Currently, it seems that the subspace type in all drivers used PCC is fixed
> and not obtained from their platform.
> IMO, PCCT is a best natural way to export it.
>
OK, but please post the changes in the *driver* you ought to use this channel
type. Your change just allows the drivers to use it but it doesn't contain
any driver making use of it. So please post that change as well to understand
the issue better. It helps in the review.
--
Regards,
Sudeep
next prev parent reply other threads:[~2023-09-18 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 11:57 Huisong Li
2023-09-14 16:13 ` Sudeep Holla
2023-09-15 7:04 ` lihuisong (C)
2023-09-18 8:43 ` Sudeep Holla [this message]
2023-09-19 11:51 ` lihuisong (C)
2023-09-20 6:47 ` [PATCH v2 0/2] " Huisong Li
2023-09-20 6:47 ` [PATCH v2 1/2] " Huisong Li
2023-09-20 6:47 ` [PATCH v2 2/2] soc: kunpeng_hccs: add the check for " Huisong Li
2023-09-20 14:11 ` Sudeep Holla
2023-09-21 2:27 ` lihuisong (C)
2023-09-28 11:40 ` lihuisong (C)
2023-09-29 11:27 ` Sudeep Holla
2023-10-07 2:45 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918084355.rzh7k6y7uuaitanj@bogus \
--to=sudeep.holla@arm.com \
--cc=lihuisong@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®