From: Huan Yang <link@vivo.com>
To: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev (open list:DATA ACCESS MONITOR),
linux-mm@kvack.org (open list:DATA ACCESS MONITOR),
linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, Huan Yang <link@vivo.com>
Subject: [PATCH] mm/damon/core: remove unnecessary si_meminfo invoke.
Date: Mon, 18 Sep 2023 17:49:34 +0800 [thread overview]
Message-ID: <20230918094934.18123-1-link@vivo.com> (raw)
si_meminfo() will read and assign more info not just free/ram pages.
For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages
is ok to save cpu.
Signed-off-by: Huan Yang <link@vivo.com>
---
mm/damon/core.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index bcd2bd9d6c10..1cddee9ae73b 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1278,14 +1278,16 @@ static bool kdamond_need_stop(struct damon_ctx *ctx)
return true;
}
-static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
+static unsigned long __damons_get_wmark_free_mem_rate(void)
{
- struct sysinfo i;
+ return global_zone_page_state(NR_FREE_PAGES) * 1000 / totalram_pages();
+}
+static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
+{
switch (metric) {
case DAMOS_WMARK_FREE_MEM_RATE:
- si_meminfo(&i);
- return i.freeram * 1000 / i.totalram;
+ return __damons_get_wmark_free_mem_rate();
default:
break;
}
--
2.34.1
next reply other threads:[~2023-09-18 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 9:49 Huan Yang [this message]
2023-09-18 11:11 ` SeongJae Park
[not found] <2feda3fb-7306-4ee7-9be3-a3990b6e9c43@vivo.com>
2023-09-18 23:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918094934.18123-1-link@vivo.com \
--to=link@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®