From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09267CD13D2 for ; Mon, 18 Sep 2023 12:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241309AbjIRMkR (ORCPT ); Mon, 18 Sep 2023 08:40:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241553AbjIRMkI (ORCPT ); Mon, 18 Sep 2023 08:40:08 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE40A4 for ; Mon, 18 Sep 2023 05:40:02 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-773b18cf900so105791685a.0 for ; Mon, 18 Sep 2023 05:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695040801; x=1695645601; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zj7R4MqD+4gW8A6fnkAfuuqO+18Hs8aMyw+H+x1HxN8=; b=crUc0EzLroJkQbVFBOsItsYr1HLQD2riaD0qtvyV+7Zqi/pGMSC50Hsfj/KB4WehRQ TaLdd2ipYy3jXqy/atoREGecG7XAQc/SR5W+cycMqkHdKIOWzkMJDFCGNtkktEIWjz0X 0xu5Oz08bGvSqDF5KFzD2kUCD0TuNhQiRarz/30jep3Btc3K7LrAuZFGbbglBBiiYU9W z/ltJ5i7TFtPr7AHfW7ucDun9t2jeDONuhxTFmtVDPs9qmtw6W82HuZGFfZprxKsHbWz gYwKaBwlQnqZJaPeJ4GebKDnLTSyc6ACe5QLgvPi4TWPJPm1QLhglIF5YS1FlsqNZzV4 Ormg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695040801; x=1695645601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zj7R4MqD+4gW8A6fnkAfuuqO+18Hs8aMyw+H+x1HxN8=; b=PBiByyIY3kzf/Fg8QITpDBOPIt7FcFxje46Ru4oRJ8kAy1OP/GJd8gn/QDbxKFb8Bw BV6+UIgGr//mUIZxqLQ1dxh2UeS8fghS+QwwfruJMdqqB8zegnPZ+5RKXSlTjVKNTHWy AhmvrNrUZbjmFdNH851XdEWEhrBSFXHe+kMzqSbT+96kTpGL8xj82lHFb+ti804h3kBp phdnkmHvRscKDPyd0BaU0sc+oR+wrlMEGDh+C+1awwaNXZ6SCGezm+GnX+xLxJQ9C52D nQIH8ExXAqT7JP486xKuEqt6ceHZebqbhqsPY3CNe/sZfa0YnEwF0SbrfyI92gqrH1G0 osJA== X-Gm-Message-State: AOJu0YzrHAlKtxF29hbVgMbnAq3Ndbr6RrI9cxk1bXPowdS2zyOUntne nfaZ1OVp4J3Q7ABuoM2T9LNkgg== X-Google-Smtp-Source: AGHT+IEcv0qE4M4jo2rCl851+S9CmbO6Vad2hVtKFtek2cuEzQB+x2yvhvfhgkJNlojCYZZBbQ7Ybg== X-Received: by 2002:a05:620a:2944:b0:76f:5b9:3f29 with SMTP id n4-20020a05620a294400b0076f05b93f29mr11358576qkp.2.1695040801514; Mon, 18 Sep 2023 05:40:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id v5-20020ae9e305000000b0076d9e298928sm3094857qkf.66.2023.09.18.05.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 05:40:01 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiDXk-0004AT-Au; Mon, 18 Sep 2023 09:40:00 -0300 Date: Mon, 18 Sep 2023 09:40:00 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Alex Williamson , oushixiong , Yishai Hadas , Shameer Kolothum , Brett Creeley , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] vfio/pds: Use proper PF device access helper Message-ID: <20230918124000.GB13795@ziepe.ca> References: <20230914021332.1929155-1-oushixiong@kylinos.cn> <20230915125858.72b75a16.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 16, 2023 at 09:53:29AM +0000, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Saturday, September 16, 2023 2:59 AM > > > > On Thu, 14 Sep 2023 10:13:32 +0800 > > oushixiong wrote: > > > > > From: Shixiong Ou > > > > > > The pci_physfn() helper exists to support cases where the physfn > > > field may not be compiled into the pci_dev structure. We've > > > declared this driver dependent on PCI_IOV to avoid this problem, > > > but regardless we should follow the precedent not to access this > > > field directly. > > > > > > Signed-off-by: Shixiong Ou > > > --- > > > > > > This patch changes the subject line and commit log, and the previous > > > patch's links is: > > > > > https://patchwork.kernel.org/project/kvm/patch/20230911080828.6 > > 35184-1-oushixiong@kylinos.cn/ > > > > Kevin & Jason, > > > > I assume your R-b's apply to this version as well. Thanks, > > > > yes. yes