From: Kaiwei Liu <kaiwei.liu@unisoc.com>
To: Vinod Koul <vkoul@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
kaiwei liu <liukaiwei086@gmail.com>,
Wenming Wu <wenming.wu@unisoc.com>
Subject: [PATCH V2] dmaengine: sprd: add dma mask interface in probe
Date: Tue, 19 Sep 2023 10:30:50 +0800 [thread overview]
Message-ID: <20230919023050.3777-1-kaiwei.liu@unisoc.com> (raw)
In the probe of DMA, the default addressing range is 32 bits,
while the actual DMA hardware addressing range used is 36 bits.
So add dma_set_mask_and_coherent function to match DMA
addressing range.
Signed-off-by: Kaiwei Liu <kaiwei.liu@unisoc.com>
---
Change in V2:
-Change subject line.
-Modify error message to make it more readable.
---
drivers/dma/sprd-dma.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 20c3cb1ef2f5..0e146550dfbb 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -1115,6 +1115,15 @@ static int sprd_dma_probe(struct platform_device *pdev)
u32 chn_count;
int ret, i;
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(36));
+ if (ret) {
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
+ if (ret) {
+ dev_err(&pdev->dev, "dma_set_mask_and_coherent failed\n");
+ return ret;
+ }
+ }
+
/* Parse new and deprecated dma-channels properties */
ret = device_property_read_u32(&pdev->dev, "dma-channels", &chn_count);
if (ret)
--
2.17.1
next reply other threads:[~2023-09-19 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 2:30 Kaiwei Liu [this message]
2023-09-19 3:23 ` Baolin Wang
2023-09-19 7:38 ` liu kaiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919023050.3777-1-kaiwei.liu@unisoc.com \
--to=kaiwei.liu@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liukaiwei086@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=vkoul@kernel.org \
--cc=wenming.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®