mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Subject: [PATCH] kernel-doc: add a warning prefix option
Date: Mon, 18 Sep 2023 19:34:15 -0700	[thread overview]
Message-ID: <20230919023415.4744-1-rdunlap@infradead.org> (raw)

Add an environment variable ("KDOC_LABEL") for use by scripts/kernel-doc.
This variable instructs kernel-doc to label each "warning:" line with
a prefix of the KDOC_LABEL value. E.g., using
  KDOC_LABEL="doc" ./scripts/kernel-doc -none -Wall kernel/panic.c
causes kernel-doc warnings to be emitted as "doc warning:", like this:
  kernel/panic.c:497: doc warning: No description found for return value of 'print_tainted'

This can aid either in finding or eliminating kernel-doc warnings.
'sparse' does something similar to this, although it uses a command line
option (-fdiagnostic-prefix[=prefix]).

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 scripts/kernel-doc |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff -- a/scripts/kernel-doc b/scripts/kernel-doc
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc
@@ -127,6 +127,7 @@ if ($#ARGV == -1) {
 }
 
 my $kernelversion;
+my $line_label;
 my ($sphinx_major, $sphinx_minor, $sphinx_patch);
 
 my $dohighlight = "";
@@ -439,6 +440,16 @@ sub get_kernel_version() {
     return $version;
 }
 
+# get line label from env
+sub get_line_label() {
+    my $label = '';
+
+    if (defined($ENV{'KDOC_LABEL'})) {
+	$label = $ENV{'KDOC_LABEL'} . " ";
+    }
+    return $label;
+}
+
 #
 sub print_lineno {
     my $lineno = shift;
@@ -450,7 +461,7 @@ sub print_lineno {
 sub emit_warning {
     my $location = shift;
     my $msg = shift;
-    print STDERR "$location: warning: $msg";
+    print STDERR "$location: ${line_label}warning: $msg";
     ++$warnings;
 }
 ##
@@ -2360,6 +2371,8 @@ if ($output_mode eq "rst") {
 
 $kernelversion = get_kernel_version();
 
+$line_label = get_line_label();
+
 # generate a sequence of code that will splice in highlighting information
 # using the s// operator.
 for (my $k = 0; $k < @highlights; $k++) {

             reply	other threads:[~2023-09-19  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  2:34 Randy Dunlap [this message]
2023-09-19  4:08 ` Matthew Wilcox
2023-09-19  4:30   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919023415.4744-1-rdunlap@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®