From: Alice Ryhl <aliceryhl@google.com>
To: manmshuk@gmail.com
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: error: Markdown style nit
Date: Tue, 19 Sep 2023 11:42:56 +0000 [thread overview]
Message-ID: <20230919114256.333055-1-aliceryhl@google.com> (raw)
In-Reply-To: <20230906204857.85619-1-manmshuk@gmail.com>
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
>
> Signed-off-by: Manmohan Shukla <manmshuk@gmail.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..6233021daa8a 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -133,7 +133,7 @@ pub fn to_errno(self) -> core::ffi::c_int {
> /// Returns the error encoded as a pointer.
> #[allow(dead_code)]
> pub(crate) fn to_ptr<T>(self) -> *mut T {
> - // SAFETY: self.0 is a valid error due to its invariant.
> + // SAFETY: `self.0` is a valid error due to its invariant.
> unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> }
>
> --
> 2.34.1
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
next prev parent reply other threads:[~2023-09-19 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 20:48 Manmohan Shukla
2023-09-15 9:52 ` Vincenzo Palazzo
2023-09-19 11:42 ` Alice Ryhl [this message]
2023-09-20 13:09 ` Benno Lossin
2023-09-20 18:05 ` Finn Behrens
2023-09-20 23:01 ` Andreas Hindborg (Samsung)
2023-09-21 0:24 ` Jianguo Bao
2023-10-08 20:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919114256.333055-1-aliceryhl@google.com \
--to=aliceryhl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manmshuk@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®