From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC37CD5BA0 for ; Tue, 19 Sep 2023 12:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbjISMN0 convert rfc822-to-8bit (ORCPT ); Tue, 19 Sep 2023 08:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjISMNX (ORCPT ); Tue, 19 Sep 2023 08:13:23 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E0AD8F2; Tue, 19 Sep 2023 05:13:17 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 887B61FB; Tue, 19 Sep 2023 05:13:54 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 715A73F67D; Tue, 19 Sep 2023 05:13:14 -0700 (PDT) Date: Tue, 19 Sep 2023 13:13:02 +0100 From: Andre Przywara To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthias Brugger , Claudiu Beznea , Peter Rosin , Sudeep Holla , Jesper Nilsson , AngeloGioacchino Del Regno , Paul Barker , Michal Simek , Heiko Stuebner , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] arm: dts: replace Bananapi with Banana Pi Message-ID: <20230919131302.26c30a31@donnerap.manchester.arm.com> In-Reply-To: <20230918074122.73265-1-arinc.unal@arinc9.com> References: <20230918074122.73265-1-arinc.unal@arinc9.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Sep 2023 10:41:22 +0300 Arınç ÜNAL wrote: Hi, > The brand name is Banana Pi. Replace any mention of Bananapi with Banana > Pi. So in general this looks fine, and the comment change is surely a no-brainer. But I was wondering if changing the model name is something that should be done, as there might be someone relying on that? And if we go there: "git grep" finds a number of boards using "Bananapi", and some others with "BananaPi", so I guess those should be changed then as well? Cheers, Andre. > > Signed-off-by: Arınç ÜNAL > --- > arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +- > arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi > index 235994a4a2eb..ef532494fc9d 100644 > --- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi > +++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi > @@ -7,7 +7,7 @@ > > / { > /* > - * Bananapi M2+ v1.2 uses a GPIO line to change the effective > + * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective > * resistance on the CPU regulator's feedback pin. > */ > reg_vdd_cpux: vdd-cpux { > diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts > index a37f3fa223c7..7f0948074945 100644 > --- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts > @@ -10,7 +10,7 @@ > #include "mt6323.dtsi" > > / { > - model = "Bananapi BPI-R2"; > + model = "Banana Pi BPI-R2"; > compatible = "bananapi,bpi-r2", "mediatek,mt7623"; > > aliases {