From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92718C04AAC for ; Wed, 20 Sep 2023 16:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234119AbjITQW2 (ORCPT ); Wed, 20 Sep 2023 12:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234462AbjITQWZ (ORCPT ); Wed, 20 Sep 2023 12:22:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C33AC6; Wed, 20 Sep 2023 09:22:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6997CC433C7; Wed, 20 Sep 2023 16:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695226938; bh=zqUtIsy1908oUIkv0om6lTekNIepRDXybEdk/VA7TJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M+xHhfz+VgkgAK7YjiSKFYBP9+/3lkbcXIegoOxMwnNt1yD4+IDf9MqsUVEbxzald xcVHs1sfqoqTJRYaV9O0cZK4AaS5tU6wB2U2Ayzf4ZuGEiFCdwhv3PfuYWIDAmBVX8 eTfSTgAdDCEoI/4B+oLnlvDzYBOm8wYhmbCPRzPZQ49t91v6+BHghNmTnld+3oTweq Lj6mW7w7T9xaPYIX3Qsm3PF4j9DioR3HaiuyElhRSD4fvvObz+/Ri4hhpPpQ9ZkUUj WyJBlPXALMOI0ieVPGLQ5WOS1reBHETNWP/9QsnInbmHTzs9rETbpCf5px8m+MUnkZ ga+PcltMZoPug== Date: Wed, 20 Sep 2023 18:22:14 +0200 From: Christian Brauner To: Linus Torvalds Cc: Jeff Layton , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] timestamp fixes Message-ID: <20230920-fixpunkt-besingen-128f43c16416@brauner> References: <20230918-hirte-neuzugang-4c2324e7bae3@brauner> <2020b8dfd062afb41cd8b74f1a41e61de0684d3f.camel@kernel.org> <20230919-kranz-entsagen-064754671396@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230919-kranz-entsagen-064754671396@brauner> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 19, 2023 at 10:28:11AM +0200, Christian Brauner wrote: > > Christian - I'm just going to assume that you'll sort this out and > > I'll get a new pull request at some point. Holler if you think > > something else is needed, ok? > > I'll take care of it and will send you a new pull request once > everything's sorted. Thanks for looking! In the meantime we had a report that unconditionally enabling multi-grain timestamps causes a regression for some users workloads. So, the honest thing is to revert the five commits that introduced the infrastructure on top of the cleanup we did for v6.6. Jeff and Jan agreed and we can give it another go for v6.7+. The general improvements to timestamp handling and related cleanup stand on their. I'll be putting the reverts into -next now and I'll get you a pull request by the end of the week. In case you'd rather do it right now it's already here: git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.6-rc3.vfs.ctime.revert I'd put something like: Users reported regressions due to enabling multi-grained timestamps unconditionally because timestamps appeared stale and could break compilation. As no clear consensus on a solution has come up and the discussion has gone back to the drawing board whether we should even expose this to userspace, revert the infrastructure changes for. If it isn't code that's here to stay, make it go away. Sorry for the inconvenience. Christian