From: Zhang Hui <masonzhang.xiaomi@gmail.com>
To: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stanley.chu@mediatek.com, peng.zhou@mediatek.com,
yujiaochen@xiaomi.com, yudongbin@xiaomi.com,
zhanghui31@xiaomi.com
Subject: [PATCH] scsi: ufs: core: Do not access null point in ufshpb_remove
Date: Wed, 20 Sep 2023 17:12:26 +0800 [thread overview]
Message-ID: <20230920091226.55663-1-zhanghui31@xiaomi.com> (raw)
From: zhanghui <zhanghui31@xiaomi.com>
If hpb is not enabled or not allowed, some points will not be allocated in
init flow, so access them will trigger KE in ufshpb remove flow.
Call trace in rmmod ko:
destroy_workqueue+0x1c/0x234
ufshpb_remove+0x40/0x50
ufshcd_remove+0x3c/0xd0
...
Signed-off-by: zhanghui <zhanghui31@xiaomi.com>
---
drivers/ufs/core/ufshpb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c
index 255f8b38d0c2..fa345e161cb8 100644
--- a/drivers/ufs/core/ufshpb.c
+++ b/drivers/ufs/core/ufshpb.c
@@ -2656,6 +2656,9 @@ void ufshpb_init(struct ufs_hba *hba)
void ufshpb_remove(struct ufs_hba *hba)
{
+ if (!ufshpb_is_allowed(hba) || !hba->dev_info.hpb_enabled)
+ return;
+
mempool_destroy(ufshpb_page_pool);
mempool_destroy(ufshpb_mctx_pool);
kmem_cache_destroy(ufshpb_mctx_cache);
--
2.34.1
next reply other threads:[~2023-09-20 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 9:12 Zhang Hui [this message]
2023-09-20 14:38 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920091226.55663-1-zhanghui31@xiaomi.com \
--to=masonzhang.xiaomi@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peng.zhou@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=yudongbin@xiaomi.com \
--cc=yujiaochen@xiaomi.com \
--cc=zhanghui31@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®