mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 05/11] Staging: rtl8192e: Rename variable pPendingBA
Date: Wed, 20 Sep 2023 20:25:09 -0700	[thread overview]
Message-ID: <20230921032515.96152-6-tdavies@darkphysics.net> (raw)
In-Reply-To: <20230921032515.96152-1-tdavies@darkphysics.net>

Rename variable pPendingBA to pending_ba to fix checkpatch warning Avoid
CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 621dbca7716a..e6892bb7958c 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -303,7 +303,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 {
 	struct ieee80211_hdr_3addr *rsp = NULL;
-	struct ba_record *pPendingBA, *pAdmittedBA;
+	struct ba_record *pending_ba, *pAdmittedBA;
 	struct tx_ts_record *pTS = NULL;
 	u8 *dst = NULL, *pDialogToken = NULL, *tag = NULL;
 	u16 *pStatusCode = NULL, *pBaTimeoutVal = NULL;
@@ -345,15 +345,15 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 	}
 
 	pTS->bAddBaReqInProgress = false;
-	pPendingBA = &pTS->TxPendingBARecord;
+	pending_ba = &pTS->TxPendingBARecord;
 	pAdmittedBA = &pTS->TxAdmittedBARecord;
 
 	if (pAdmittedBA->b_valid) {
 		netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n",
 			   __func__);
 		return -1;
-	} else if (!pPendingBA->b_valid ||
-		   (*pDialogToken != pPendingBA->dialog_token)) {
+	} else if (!pending_ba->b_valid ||
+		   (*pDialogToken != pending_ba->dialog_token)) {
 		netdev_warn(ieee->dev,
 			    "%s(): ADDBA Rsp. BA invalid, DELBA!\n",
 			    __func__);
@@ -363,7 +363,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 		netdev_dbg(ieee->dev,
 			   "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n",
 			   __func__, *pStatusCode);
-		deactivate_ba_entry(ieee, pPendingBA);
+		deactivate_ba_entry(ieee, pending_ba);
 	}
 
 	if (*pStatusCode == ADDBA_STATUS_SUCCESS) {
@@ -376,7 +376,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 
 		pAdmittedBA->dialog_token = *pDialogToken;
 		pAdmittedBA->ba_timeout_value = *pBaTimeoutVal;
-		pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl;
+		pAdmittedBA->ba_start_seq_ctrl = pending_ba->ba_start_seq_ctrl;
 		pAdmittedBA->ba_param_set = *pBaParamSet;
 		deactivate_ba_entry(ieee, pAdmittedBA);
 		activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
-- 
2.39.2


  parent reply	other threads:[~2023-09-21  3:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  3:25 [PATCH 00/11] Staging: rtl8192e: Function and Variable rename series Tree Davies
2023-09-21  3:25 ` [PATCH 01/11] Staging: rtl8192e: Rename variable Time Tree Davies
2023-09-21  3:25 ` [PATCH 02/11] Staging: rtl8192e: Rename variable pAdmittedBa Tree Davies
2023-09-21  3:25 ` [PATCH 03/11] Staging: rtl8192e: Rename variable pPendingBa Tree Davies
2023-09-21  3:25 ` [PATCH 04/11] Staging: rtl8192e: Rename variable Dst Tree Davies
2023-09-21  3:25 ` Tree Davies [this message]
2023-09-21  3:25 ` [PATCH 06/11] Staging: rtl8192e: Rename variable Addr Tree Davies
2023-09-21  3:25 ` [PATCH 07/11] Staging: rtl8192e: Rename variable pStatusCode Tree Davies
2023-09-21  3:25 ` [PATCH 08/11] Staging: rtl8192e: Rename variable Policy Tree Davies
2023-09-21  3:25 ` [PATCH 09/11] Staging: rtl8192e: Rename function GetTs() Tree Davies
2023-09-21  3:25 ` [PATCH 10/11] Staging: rtl8192e: Rename function TSInitialize Tree Davies
2023-09-21  3:25 ` [PATCH 11/11] Staging: rtl8192e: Rename variable StatusCode Tree Davies
2023-09-21 15:56 ` [PATCH 00/11] Staging: rtl8192e: Function and Variable rename series Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921032515.96152-6-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=anjan@momi.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®