mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wenhua Lin <Wenhua.Lin@unisoc.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	wenhua lin <wenhua.lin1994@gmail.com>,
	Wenhua Lin <Wenhua.Lin@unisoc.com>,
	Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: [PATCH V2 4/4] gpio: sprd: Support 8 banks EIC controller
Date: Thu, 21 Sep 2023 17:00:27 +0800	[thread overview]
Message-ID: <20230921090027.11136-5-Wenhua.Lin@unisoc.com> (raw)
In-Reply-To: <20230921090027.11136-1-Wenhua.Lin@unisoc.com>

In order to solve the problem of insufficient eic,
it supports 8 banks of eic controller, each bank contains 8 eic.

Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
 drivers/gpio/gpio-eic-sprd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index e85addbdf8aa..6bb002060c3e 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -51,10 +51,10 @@
 #define SPRD_EIC_SYNC_DATA		0x1c
 
 /*
- * The digital-chip EIC controller can support maximum 3 banks, and each bank
+ * The digital-chip EIC controller can support maximum 8 banks, and each bank
  * contains 8 EICs.
  */
-#define SPRD_EIC_MAX_BANK		3
+#define SPRD_EIC_MAX_BANK		8
 #define SPRD_EIC_PER_BANK_NR		8
 #define SPRD_EIC_DATA_MASK		GENMASK(7, 0)
 #define SPRD_EIC_BIT(x)			((x) & (SPRD_EIC_PER_BANK_NR - 1))
@@ -615,9 +615,9 @@ static int sprd_eic_probe(struct platform_device *pdev)
 
 	for (i = 0; i < SPRD_EIC_MAX_BANK; i++) {
 		/*
-		 * We can have maximum 3 banks EICs, and each EIC has
+		 * We can have maximum 8 banks EICs, and each EIC has
 		 * its own base address. But some platform maybe only
-		 * have one bank EIC, thus base[1] and base[2] can be
+		 * have one bank EIC, thus base[1] and base[7] can be
 		 * optional.
 		 */
 		res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-- 
2.17.1


  parent reply	other threads:[~2023-09-21 20:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  9:00 [PATCH V2 0/4] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
2023-09-21  9:00 ` [PATCH V2 1/4] gpio: sprd: In the sleep state, the eic debounce clk must be forced open Wenhua Lin
2023-09-21 11:23   ` Andy Shevchenko
2024-01-02  8:34     ` wenhua lin
2023-09-27  9:08   ` Baolin Wang
2024-01-02  8:42     ` wenhua lin
2023-09-21  9:00 ` [PATCH V2 2/4] gpio: sprd: Clear interrupt after set the interrupt type Wenhua Lin
2023-09-21 11:24   ` Andy Shevchenko
2024-01-03 12:06     ` wenhua lin
2023-09-27  9:15   ` Baolin Wang
2023-09-21  9:00 ` [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number Wenhua Lin
2023-09-21 11:27   ` Andy Shevchenko
2024-01-04  2:31     ` wenhua lin
2023-09-27  9:24   ` Baolin Wang
2024-01-03 12:04     ` wenhua lin
2023-09-21  9:00 ` Wenhua Lin [this message]
2023-09-27  9:28   ` [PATCH V2 4/4] gpio: sprd: Support 8 banks EIC controller Baolin Wang
2024-01-03 12:03     ` wenhua lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921090027.11136-5-Wenhua.Lin@unisoc.com \
    --to=wenhua.lin@unisoc.com \
    --cc=andy@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=wenhua.lin1994@gmail.com \
    --cc=xiongpeng.wu@unisoc.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®