From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC605E7D0B4 for ; Thu, 21 Sep 2023 23:25:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbjIUXZb (ORCPT ); Thu, 21 Sep 2023 19:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230228AbjIUXZX (ORCPT ); Thu, 21 Sep 2023 19:25:23 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED44158C0A; Thu, 21 Sep 2023 10:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=NFF+PoVjyhgtWD7FmDOjIgO2GmI0ihAD+1rw5BwVsZ8=; b=BEz53JSgCDIVR76qrqB2EzybNq H+/OEeFax8X9OejHzzo4DUIxxDOBwyZ/zk7iFMJW/QsIQmQSRBapHUbfjj6gcsC85pNyiWXAGI3VQ VR2Ln9b/DpSe3bswJ2FjHkW2dTnV++eWUp8JBb2bWJiYNGfzJ72zbKlxOOglYqJEhjbg=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:54768 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qjJrb-00071a-CE; Thu, 21 Sep 2023 09:37:05 -0400 Date: Thu, 21 Sep 2023 09:37:02 -0400 From: Hugo Villeneuve To: m.brock@vanmierlo.com Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hvilleneuve@dimonoff.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org Message-Id: <20230921093702.fd28e0dfe06cb5ee61f43494@hugovil.com> In-Reply-To: <35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com> References: <20230920152015.1376838-1-hugo@hugovil.com> <20230920152015.1376838-4-hugo@hugovil.com> <35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Sep 2023 12:29:13 +0200 m.brock@vanmierlo.com wrote: > Hugo Villeneuve wrote on 2023-09-20 17:20: > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > @@ -21,8 +21,8 @@ Optional properties: > > the second cell is used to specify the GPIO polarity: > > 0 = active high, > > 1 = active low. > > -- irda-mode-ports: An array that lists the indices of the port that > > - should operate in IrDA mode. > > +- nxp,irda-mode-ports: An array that lists the indices of the port > > that > > + should operate in IrDA mode. > > - nxp,modem-control-line-ports: An array that lists the indices of > > the port that > > Are you sure you want this line removed? Hi Maarten, the line "- nxp,modem-control-line-ports..." is not removed, but because it starts with a dash in the source file, maybe it is confusing when looking at the patch only? Hugo. > > > should have shared GPIO lines configured as > > modem control lines. > > @@ -80,8 +80,8 @@ Optional properties: > > the second cell is used to specify the GPIO polarity: > > 0 = active high, > > 1 = active low. > > -- irda-mode-ports: An array that lists the indices of the port that > > - should operate in IrDA mode. > > +- nxp,irda-mode-ports: An array that lists the indices of the port > > that > > + should operate in IrDA mode. > > - nxp,modem-control-line-ports: An array that lists the indices of > > the port that > > Same here. > > > should have shared GPIO lines configured as > > modem control lines. > > Greets, > Maarten > >