From: Wyes Karny <wyes.karny@amd.com>
To: <lenb@kernel.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Wyes Karny <wyes.karny@amd.com>
Subject: [PATCH] tools/power turbostat: Increase the limit for fd opened
Date: Fri, 22 Sep 2023 09:28:23 +0000 [thread overview]
Message-ID: <20230922092823.478042-1-wyes.karny@amd.com> (raw)
When running turbostat, a system with 512 cpus reaches the limit for
maximum number of file descriptors that can be opened. To solve this
problem, the limit is raised to 2^15, which is a large enough number.
Below data is collected from AMD server systems while running turbostat:
|-----------+-------------------------------|
| # of cpus | # of opened fds for turbostat |
|-----------+-------------------------------|
| 128 | 260 |
|-----------+-------------------------------|
| 192 | 388 |
|-----------+-------------------------------|
| 512 | 1028 |
|-----------+-------------------------------|
So, the new max limit would be sufficient up to 2^14 cpus.
Signed-off-by: Wyes Karny <wyes.karny@amd.com>
---
tools/power/x86/turbostat/turbostat.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 9a10512e3407..23f1fe58289a 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -6717,6 +6717,18 @@ void cmdline(int argc, char **argv)
}
}
+void set_rlimit(void)
+{
+ struct rlimit limit;
+
+ limit.rlim_cur = 0x8000;
+ limit.rlim_max = 0x8000;
+
+ if (setrlimit(RLIMIT_NOFILE, &limit) < 0) {
+ err(1, "Failed to set rlimit");
+ }
+}
+
int main(int argc, char **argv)
{
outf = stderr;
@@ -6729,6 +6741,9 @@ int main(int argc, char **argv)
probe_sysfs();
+ if (!getuid())
+ set_rlimit();
+
turbostat_init();
msr_sum_record();
--
2.34.1
next reply other threads:[~2023-09-22 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:28 Wyes Karny [this message]
2023-09-22 20:48 ` Doug Smythies
2023-09-27 5:16 ` Wyes Karny
2023-09-29 15:32 ` Doug Smythies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922092823.478042-1-wyes.karny@amd.com \
--to=wyes.karny@amd.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®