From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5963DCD4846 for ; Fri, 22 Sep 2023 17:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232893AbjIVRDV (ORCPT ); Fri, 22 Sep 2023 13:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjIVRDS (ORCPT ); Fri, 22 Sep 2023 13:03:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C39C194; Fri, 22 Sep 2023 10:03:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E909C433C8; Fri, 22 Sep 2023 17:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695402192; bh=qa/QJ12DIUWvIeySIX2g6kqd2yUHHXJ+BRw50a4IKNU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uZWF7kJrm5w73mco/RN5kh0tFZqol/wzUHts2vidpRz38ZzJryh0F8Jo8FNJ1KjRS fvytGPaP6DT92lWdNVq/FOf7os8h8kRVgIb6Q+blcoSlcD8L3qWYBYT5RU0unpOhYv ZQz8Myb6yh3K4y1JaIiCCoPWXMFcaasTV8Kdbmps= Date: Fri, 22 Sep 2023 10:03:10 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , =?ISO-8859-1?Q? "Michal_Koutn=FD" ?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] mm: memcg: fix tracking of pending stats updates values Message-Id: <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> In-Reply-To: <20230922082542.466579-1-yosryahmed@google.com> References: <20230922082542.466579-1-yosryahmed@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed wrote: > While working on adjacent code [1], I realized that the values passed > into memcg_rstat_updated() to keep track of the magnitude of pending > updates is consistent. It is mostly in pages, but sometimes it can be in > bytes or KBs. Fix that. Clashes with "memcg: remove unused do_memsw_account in memcg1_stat_format", and maybe other things. Can you please redo against mm-unsstable or linux-next?