From: David Sterba <dsterba@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Layton <jlayton@kernel.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [GIT PULL v2] timestamp fixes
Date: Fri, 22 Sep 2023 12:19:43 +0200 [thread overview]
Message-ID: <20230922101943.GA13697@twin.jikos.cz> (raw)
In-Reply-To: <CAHk-=whAwTJduUZTrsLFnj1creZMfO7eCNERHXZQmzX+qLqZMA@mail.gmail.com>
On Thu, Sep 21, 2023 at 12:28:13PM -0700, Linus Torvalds wrote:
> On Thu, 21 Sept 2023 at 11:51, Jeff Layton <jlayton@kernel.org> wrote:
> >
> > We have many, many inodes though, and 12 bytes per adds up!
>
> That was my thinking, but honestly, who knows what other alignment
> issues might eat up some - or all - of the theoreteical 12 bytes.
>
> It might be, for example, that the inode is already some aligned size,
> and that the allocation alignment means that the size wouldn't
> *really* shrink at all.
>
> So I just want to make clear that I think the 12 bytes isn't
> necessarily there. Maybe you'd get it, maybe it would be hidden by
> other things.
I think all filesystem developers appreciate when struct inode shrinks,
it's usually embedded with additional data and the size grows. I'm on a
mission to squeeze btrfs_inode under 1024 so it fits better to the slab
pages and currently it's about 1100 bytes. 1024 is within reach but it
gets harder to find potential space savings.
next prev parent reply other threads:[~2023-09-22 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 11:20 Christian Brauner
2023-09-21 18:24 ` Linus Torvalds
2023-09-21 18:51 ` Jeff Layton
2023-09-21 19:28 ` Linus Torvalds
2023-09-21 19:46 ` Linus Torvalds
2023-09-21 21:57 ` Jeff Layton
2023-09-22 12:28 ` Christian Brauner
2023-09-22 10:19 ` David Sterba [this message]
2023-09-23 6:36 ` Amir Goldstein
2023-09-23 17:48 ` Linus Torvalds
2023-09-23 19:30 ` Theodore Ts'o
2023-09-23 20:03 ` Linus Torvalds
2023-09-23 22:07 ` Theodore Ts'o
2023-09-23 23:31 ` Linus Torvalds
2023-09-23 21:29 ` Amir Goldstein
2023-09-24 10:26 ` Christian Brauner
2023-09-25 11:22 ` Jeff Layton
2023-09-25 16:02 ` Linus Torvalds
2023-09-22 12:24 ` Christian Brauner
2023-09-24 8:34 ` Amir Goldstein
2023-09-24 10:15 ` Christian Brauner
2023-09-22 12:16 ` Christian Brauner
2023-09-21 20:10 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922101943.GA13697@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®