From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A03BCCD484B for ; Fri, 22 Sep 2023 18:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232987AbjIVSAO (ORCPT ); Fri, 22 Sep 2023 14:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233807AbjIVR7e (ORCPT ); Fri, 22 Sep 2023 13:59:34 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EAF04207 for ; Fri, 22 Sep 2023 10:57:44 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-59e8ebc0376so35163397b3.2 for ; Fri, 22 Sep 2023 10:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695405463; x=1696010263; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=TWhlillKWVcEeVnrDyY8Q3IYayRPjR5OTdgTyF2A4S0=; b=KF/mZ9HKfn/WA0ZSf/lvAI/cCURUB5ub3z+0/CTXUMMlv+Tym0E4kqnaDycqPdIVzb Kzg/IyiwSilA9xiMNMXhEaf+Kti6bcrddodaJbrRYcALEiKJ3xPGVRNUoqKJYPL4sYe+ 8Wtdixfgwt4qHlbh6c/3jWY/1I7VWb1ERxPLo1zWs9CbxsCjzms5SodHdiLP7iVmDfTa 0AC4QxCBiILwumu7weq3dLnxncip3+YMFKTLF7xZWLTjX+ENJzxRzUeuh63VRg5/Ei0Q lc/zIx8N+5pNxfFH2zacDEz/Ckqwji3fKULiTVnh46f5a0yC9ObEn6wTgdjff5datgEt mGJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695405463; x=1696010263; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TWhlillKWVcEeVnrDyY8Q3IYayRPjR5OTdgTyF2A4S0=; b=KWfyXwKxv8BCNWacxQT9OZemLEoy+OpP31wqvfnb0NUbhTf8328/DwdXF7r2sy0bvw m6DRQZ7WIH3LANdoJxFJer4SdeJIggomn2gAF6Vxf2dU4NBf4F8CV//QgZND8kOByGb0 U9GF5F20UgIRe7Ma9WECAfy6VHSXXEr/rvjfr22+RUJTvk4pJsG7yVZGb16BDU3jMJFE 39aG648kz8CZXWRtz1Q+iVmTPrZVGRNi7mDQ9JHOmNW2wD3MMKvD9yH97XwLhIGZztWY i4DykrjnI9oQwf/6pAWUbEijstcYlPxvyoePVhHqe72a5ZE5qckQQdPYCXssv7C48ut9 sFpw== X-Gm-Message-State: AOJu0YwfJIiFCYxtxsHuXzFGQuFw4H6Pr4sn1pwQSxkoPgH2ZN/MmWAa p21N5123bFZp2O+yTb6xvpYfCYUwInJCeADh X-Google-Smtp-Source: AGHT+IHEaQf18bKeGdlnoKYY1mRA3LamvJr+H7xbuexfhbmBx44hNVCD9XA/gUtzgCmW8MrZ2JYiKVQxx+nJcwLq X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a0d:ec49:0:b0:59b:d857:8317 with SMTP id r9-20020a0dec49000000b0059bd8578317mr6978ywn.2.1695405463484; Fri, 22 Sep 2023 10:57:43 -0700 (PDT) Date: Fri, 22 Sep 2023 17:57:38 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.515.g380fc7ccd1-goog Message-ID: <20230922175741.635002-1-yosryahmed@google.com> Subject: [PATCH v2 0/2] mm: memcg: fix tracking of pending stats updates values From: Yosry Ahmed To: Andrew Morton , Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "=?UTF-8?q?Michal=20Koutn=C3=BD?=" , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While working on adjacent code [1], I realized that the values passed into memcg_rstat_updated() to keep track of the magnitude of pending updates is consistent. It is mostly in pages, but sometimes it can be in bytes or KBs. Fix that. Patch 1 reworks memcg_page_state_unit() so that we can reuse it in patch 2 to check and normalize the units of state updates. [1]https://lore.kernel.org/lkml/20230921081057.3440885-1-yosryahmed@google.com/ v1 -> v2: - Rebased on top of mm-unstable. Yosry Ahmed (2): mm: memcg: refactor page state unit helpers mm: memcg: normalize the value passed into memcg_rstat_updated() mm/memcontrol.c | 64 +++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 51 insertions(+), 13 deletions(-) -- 2.42.0.515.g380fc7ccd1-goog