From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3E5CE7A81 for ; Fri, 22 Sep 2023 21:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjIVV1j (ORCPT ); Fri, 22 Sep 2023 17:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjIVV1h (ORCPT ); Fri, 22 Sep 2023 17:27:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E9AAF for ; Fri, 22 Sep 2023 14:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695418005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=makqFmzriWHzRFEQqiRtYLztxtDFQhok61IdEbRa/ho=; b=Q40ommVVyH+mEfnhMUl349vVeQAMelJvivYjAq5LODemKBaoLd8Sv7a7yQ7jp+bMqmVmk5 vzE6l1bfj0a7zlklkJSFBLTi9U5Ed+G6ec2mb7Kb1R5y4Sp2H8mF+DtBgfpUrNEqqH+QsA Qy03dWvIzwSXzyuMMFwuOFdX6tNE/dk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-8ndgFOH1N4SgOrxI_iqsFw-1; Fri, 22 Sep 2023 17:26:42 -0400 X-MC-Unique: 8ndgFOH1N4SgOrxI_iqsFw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66C48801779; Fri, 22 Sep 2023 21:26:41 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01BA449BB9A; Fri, 22 Sep 2023 21:26:40 +0000 (UTC) From: Paolo Bonzini To: Tom Lendacky Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Sean Christopherson , Borislav Petkov , Dave Hansen , Ingo Molnar , Thomas Gleixner , Babu Moger Subject: Re: [PATCH v2 0/3] SEV-ES TSC_AUX virtualization fix and optimization Date: Fri, 22 Sep 2023 17:24:55 -0400 Message-Id: <20230922212453.1115016-1-pbonzini@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Queued, thanks. The part that stood out in patch 2 is the removal of svm_clr_intercept(), which also applies when the initialization is done in the wrong place. Either way, svm_clr_intercept() is always going to be called by svm_recalc_instruction_intercepts() if guest has the RDTSC bit in its CPUID. So I extracted that into a separate patch and squashed the rest of patch 2 into patch 1. Paolo