From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45A5CD4F55 for ; Fri, 22 Sep 2023 10:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbjIVKaX (ORCPT ); Fri, 22 Sep 2023 06:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjIVKaT (ORCPT ); Fri, 22 Sep 2023 06:30:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F7E114 for ; Fri, 22 Sep 2023 03:30:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C8F6C433C7; Fri, 22 Sep 2023 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695378612; bh=4v5tPitvvC+iLh5RFLXHnFNkbavtiFXvg1aF+3bOFsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kgQarKTdLtuxoaC4NZKosGRLyO8VBkWlWc/uslKv/kAXhLAelpEN1IA8A29XxxYvj pO60NDNcX/kApt9EUM9KHP2ba9SsyErlIx9AQ17C/woYow0Z6ah6SbfjUi0tkLrJQV 9J+pvSfnF9SP3MIv9lICWFMbaDftHMjsTLvgUaCI= Date: Fri, 22 Sep 2023 12:30:09 +0200 From: Greg Kroah-Hartman To: Prashanth K Cc: linux-kernel@vger.kernel.org, Hongyu Xie , Mathias Nyman , stable@kernel.org, Hongyu Xie , Mathias Nyman Subject: Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running. Message-ID: <2023092256-smudge-disallow-48d3@gregkh> References: <1695374501-22649-1-git-send-email-quic_prashk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1695374501-22649-1-git-send-email-quic_prashk@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote: > From: Hongyu Xie > > [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ] > > irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared > in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it. > It's possible that you will receive thousands of interrupt requests > after initialization for 2.0 roothub. And you will get a lot of > warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be > disabled?". This amount of interrupt requests will cause the entire > system to freeze. > This problem was first found on a device with ASM2142 host controller > on it. > > [tidy up old code while moving it, reword header -Mathias] > > Cc: stable@kernel.org > Signed-off-by: Hongyu Xie > Signed-off-by: Mathias Nyman > Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/host/xhci.c | 34 +++++++++++++++++++++------------- > 1 file changed, 21 insertions(+), 13 deletions(-) What stable kernel(s) are you asking this to be applied to? greg k-h