mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: weilin.wang@intel.com
To: weilin.wang@intel.com, Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Perry Taylor <perry.taylor@intel.com>,
	Samantha Alt <samantha.alt@intel.com>,
	Caleb Biggers <caleb.biggers@intel.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: [RFC PATCH 22/25] perf stat: Add TSC support in hardware-grouping
Date: Sun, 24 Sep 2023 23:18:21 -0700	[thread overview]
Message-ID: <20230925061824.3818631-23-weilin.wang@intel.com> (raw)
In-Reply-To: <20230925061824.3818631-1-weilin.wang@intel.com>

From: Weilin Wang <weilin.wang@intel.com>

Add TSC check and create new event for it the same way as how we handle
topdown-* for now since it is not listed in an event json file either. Need
TSC to support TopdownL4-L5.

Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
 tools/perf/util/metricgroup.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index d10f6afb0..07a82fa21 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -321,6 +321,14 @@ static int setup_metric_events(const char *pmu, struct hashmap *ids,
 		}
 	}
 	if (matched_events < ids_size) {
+		struct hashmap_entry *cur;
+		size_t bkt;
+
+		hashmap__for_each_entry(ids, cur, bkt) {
+			const char *id = cur->pkey;
+
+			pr_debug("Need event %s\n", id);
+		}
 		free(metric_events);
 		return -EINVAL;
 	}
@@ -2106,11 +2114,16 @@ static int hw_aware_build_grouping(struct expr_parse_ctx *ctx,
 #define RETURN_IF_NON_ZERO(x) do { if (x) return x; } while (0)
 	hashmap__for_each_entry(ctx->ids, cur, bkt) {
 		const char *id = cur->pkey;
-		const char *special_pattern = "topdown-";
+		const char *pattern1 = "topdown-";
+		const char *pattern2 = "TSC";
 
 		pr_debug("found event %s\n", id);
-		if (!strncmp(id, special_pattern, strlen(special_pattern))) {
+		if (!strncmp(id, pattern1, strlen(pattern1)) ||
+		    !strncmp(id, pattern2, strlen(pattern2))) {
 			struct metricgroup__event_info *event;
+			/* topdown-* and TSC use dedicated registers, set as free
+			 * counter here for grouping
+			 */
 			event = event_info__new(id, "default_core", "0", false,
 						/*free_counter=*/true);
 			if (!event) {
@@ -2602,8 +2615,10 @@ int metricgroup__parse_groups(struct evlist *perf_evlist,
 		ret = hw_aware_parse_groups(perf_evlist, pmu, str,
 			    metric_no_threshold, user_requested_cpu_list, system_wide,
 			    /*fake_pmu=*/NULL, metric_events, table);
-		if (!ret)
+		if (!ret) {
+			pr_info("Hardware aware grouping completed\n");
 			return 0;
+		}
 	}
 
 	return parse_groups(perf_evlist, pmu, str, metric_no_group, metric_no_merge,
-- 
2.39.3


  parent reply	other threads:[~2023-09-25  6:21 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  6:17 [RFC PATCH 00/25] Perf stat metric grouping with hardware information weilin.wang
2023-09-25  6:18 ` [RFC PATCH 01/25] perf stat: Add hardware-grouping cmd option to perf stat weilin.wang
2023-09-26 14:50   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 02/25] perf stat: Add basic functions for the hardware-grouping stat cmd option weilin.wang
2023-09-26 15:10   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 03/25] perf pmu-events: Add functions in jevent.py weilin.wang
2023-09-26 15:17   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 04/25] perf pmu-events: Add counter info into JSON files for SapphireRapids weilin.wang
2023-09-26 15:20   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 05/25] perf pmu-events: Add event counter data for Cascadelakex weilin.wang
2023-09-25  6:18 ` [RFC PATCH 06/25] perf pmu-events: Add event counter data for Icelakex weilin.wang
2023-09-25  6:18 ` [RFC PATCH 07/25] perf stat: Add helper functions for hardware-grouping method weilin.wang
2023-09-26 15:28   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 08/25] perf stat: Add functions to get counter info weilin.wang
2023-09-26 15:37   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 09/25] perf stat: Add helper functions for hardware-grouping method weilin.wang
2023-09-26  3:37   ` Yang Jihong
2023-09-26 20:51     ` Wang, Weilin
2023-09-25  6:18 ` [RFC PATCH 10/25] perf stat: Add helper functions to " weilin.wang
2023-09-26  3:44   ` Yang Jihong
2023-09-26 15:55   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 11/25] perf stat: Add utility " weilin.wang
2023-09-26 16:02   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 12/25] perf stat: Add more functions for " weilin.wang
2023-09-25  6:18 ` [RFC PATCH 13/25] perf stat: Add functions to " weilin.wang
2023-09-26 16:18   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 14/25] perf stat: Add build string function and topdown events handling in hardware-grouping weilin.wang
2023-09-26 16:21   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 15/25] perf stat: Add function to combine metrics for hardware-grouping weilin.wang
2023-09-25  6:18 ` [RFC PATCH 16/25] perf stat: Update keyword core to default_core to adjust to the changes for events with no unit weilin.wang
2023-09-26 16:25   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 17/25] perf stat: Handle taken alone in hardware-grouping weilin.wang
2023-09-25  6:18 ` [RFC PATCH 18/25] perf stat: Handle NMI " weilin.wang
2023-09-25  6:18 ` [RFC PATCH 19/25] perf stat: Handle grouping method fall back " weilin.wang
2023-09-25  6:18 ` [RFC PATCH 20/25] perf stat: Code refactoring " weilin.wang
2023-09-25  6:18 ` [RFC PATCH 21/25] perf stat: Add tool events support " weilin.wang
2023-09-25  6:18 ` weilin.wang [this message]
2023-09-26 16:35   ` [RFC PATCH 22/25] perf stat: Add TSC " Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 23/25] perf stat: Fix a return error issue " weilin.wang
2023-09-26 16:36   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 24/25] perf stat: Add check to ensure correctness in platform that does not support hardware-grouping weilin.wang
2023-09-26 16:38   ` Liang, Kan
2023-09-25  6:18 ` [RFC PATCH 25/25] perf pmu-events: Add event counter data for Tigerlake weilin.wang
2023-09-26 16:41   ` Liang, Kan
2023-09-25 18:29 ` [RFC PATCH 00/25] Perf stat metric grouping with hardware information Ian Rogers
2023-09-26 20:40   ` Wang, Weilin
2023-09-26 14:43 ` Liang, Kan
2023-09-26 16:48   ` Liang, Kan
2023-09-26 20:40     ` Wang, Weilin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230925061824.3818631-23-weilin.wang@intel.com \
    --to=weilin.wang@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=caleb.biggers@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=perry.taylor@intel.com \
    --cc=peterz@infradead.org \
    --cc=samantha.alt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®