From: Armin Wolf <W_Armin@gmx.de>
To: markpearson@lenovo.com, jorge.lopez2@hp.com
Cc: hdegoede@redhat.com, markgross@kernel.org,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] platform/x86: Fix reference leaks
Date: Mon, 25 Sep 2023 15:28:42 +0200 [thread overview]
Message-ID: <20230925132844.72479-1-W_Armin@gmx.de> (raw)
If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). This issue likely first appeared inside the
dell-wmi-sysman driver, see
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak").
However, it also seems that the bug was copied from this driver into
the think-lmi and hp-bioscfg drivers. Maybe a more abstract
fw_attr_class could prevent such issues in the future by abstracting
away the kobject handling?
Armin Wolf (2):
platform/x86: think-lmi: Fix reference leak
platform/x86: hp-bioscfg: Fix reference leak
drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++----
drivers/platform/x86/think-lmi.c | 24 ++++++++++++++++----
2 files changed, 30 insertions(+), 8 deletions(-)
--
2.39.2
next reply other threads:[~2023-09-25 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 13:28 Armin Wolf [this message]
2023-09-25 13:28 ` [PATCH v3 1/2] platform/x86: think-lmi: Fix reference leak Armin Wolf
2023-09-25 13:28 ` [PATCH v3 2/2] platform/x86: hp-bioscfg: " Armin Wolf
2023-09-25 13:38 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925132844.72479-1-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jorge.lopez2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=markpearson@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®