From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF141E8181B for ; Tue, 26 Sep 2023 04:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbjIZE5g (ORCPT ); Tue, 26 Sep 2023 00:57:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjIZE5d (ORCPT ); Tue, 26 Sep 2023 00:57:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4703E6 for ; Mon, 25 Sep 2023 21:57:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C43CC433C7; Tue, 26 Sep 2023 04:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695704243; bh=PzV9aQcamDLYWUCJlNJtgTlBzrz5YiFxBTx0LXK3QIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SoOOo+4TJAXIv0S2LURMn9Nc06RHQX/8SrlxFj8vyxWhv8UpKlW4Bp3eu75uhgp5H 2J74JZCA7UdJmWiVHfZofC44WQYG3ikYUsi93E0kbmgwHvNlzMjGet3D7hskpCMblb bpkDLGnXEIA8tGJFzHISewIK8g4Q1UkEwoxymH8P3249j+Mh2KlPs+t1d01Y74gFE9 swqnB60qHQcQuYuqYeAor/LLzf2ZSBdJm79d25ldaPwqxaNpLRmMR+P0kv27Y5DvpX i69/TwPjYv9s0DJ/Qm/nVBv+ZTWHVwnILC+nWSJ8eVmyuYYutEEEL5YJwj3pKcx6n4 sEcdCDrY6JnJg== Date: Mon, 25 Sep 2023 21:57:21 -0700 From: Eric Biggers To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] MAINTAINERS: hardening: Add __counted_by regex Message-ID: <20230926045721.GA3118@sol.localdomain> References: <20230925172037.work.853-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925172037.work.853-kees@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees, On Mon, Sep 25, 2023 at 10:20:41AM -0700, Kees Cook wrote: > Since __counted_by annotations may also require that code be changed to > get initialization ordering correct, let's get an extra group of eyes on > code that is working on these annotations. > > Signed-off-by: Kees Cook > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 737dcc7a2155..741285b8246e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11405,6 +11405,7 @@ F: kernel/configs/hardening.config > F: mm/usercopy.c > K: \b(add|choose)_random_kstack_offset\b > K: \b__check_(object_size|heap_object)\b > +K: \b__counted_by\b > Are you sure you want to volunteer to maintain every file that contains "__counted_by"? That's what "K" does; get_maintainer.pl will list you (and linux-hardening@vger.kernel.org) for every such file. Other users of "K" have been surprised by this behavior. It seems that most people expect it to only apply to patches, not to files. Given that you're interested in using this functionality, have you considered updating checkpatch.pl to handle it in the way that you probably expect that it works? - Eric