From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3DCE7F15D for ; Wed, 27 Sep 2023 04:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbjI0ELs (ORCPT ); Wed, 27 Sep 2023 00:11:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjI0EKd (ORCPT ); Wed, 27 Sep 2023 00:10:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 570C41E3CC for ; Tue, 26 Sep 2023 15:27:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DA64C433B8; Tue, 26 Sep 2023 21:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695762596; bh=wC0dTpJgWtaku1+4SDaNJIe+CBwFB1hfHT9wzrkh5Gw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vX0KbVB0hpSZUkMK5QugE4qB2ANXXob7PmAOhter8MsdV+VgxJtUKpxCGz8nt4dA9 MpPV07PcCNeJgPRGlCFw76/2qQMNkK9jXx5OJsx3j1X4T6XfzKIFgxAc/S4MiTImcU 4RudDUmLe47HNNaHG3EuhLA76aW+LGbTeoMoQ9C0= Date: Tue, 26 Sep 2023 14:09:55 -0700 From: Andrew Morton To: Stefan Roesch Cc: David Hildenbrand , kernel-team@fb.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode Message-Id: <20230926140955.8b2627711116339af80731f2@linux-foundation.org> In-Reply-To: References: <20230926040939.516161-1-shr@devkernel.io> <20230926040939.516161-2-shr@devkernel.io> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch wrote: > > Thinking about it, what are the cons of just enabling this always and not > > exposing new toggles? Alternatively, we could make this a compile-time option. > > > > In general, LGTM, just curious if we really have to make this configurable. > > > > The only downside I can see is that it might take a longer time for some > pages to be de-duplicated (a new candidate page is added, but its > duplicate is skipped in this round). So it will take longer to > de-duplicate this page. > > I tested with more than one workload, but it might be useful to get some > data with additional workloads. I was thinking of enabling it after one or > two releases. We could keep the tunable and make it default "on"?