From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B892E7D26A for ; Tue, 26 Sep 2023 09:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234069AbjIZJJN (ORCPT ); Tue, 26 Sep 2023 05:09:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbjIZJJL (ORCPT ); Tue, 26 Sep 2023 05:09:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC3C6DE for ; Tue, 26 Sep 2023 02:09:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1E8AC433C7; Tue, 26 Sep 2023 09:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695719344; bh=EQ3gw+CGyonVOw7q786V0KhKp+/HJVjFTRG5l5JaYvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iFUmShKbYw2TTaK8PyHkqDC57kWl3Df9SASr7IonCUhrk+Ap7zW38RMkv85o8lWMX hxCTPDgAOaV7li130deJz5njt5VOIiilGEsxbTaSmcXvrwvQk7zKsYZp9BInQMUjmx grzOYrqYU2cTBU5V+RJezvUaqrw/Cp3iWBn4ZlL4= Date: Tue, 26 Sep 2023 11:09:00 +0200 From: Greg KH To: Gary Rookard Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] rtl8192e: renamed (1) mixed case variable Message-ID: <2023092617-skydiver-unsworn-18f8@gregkh> References: <20230925151157.3893-1-garyrookard@fastmail.org> <20230925151157.3893-2-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925151157.3893-2-garyrookard@fastmail.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2023 at 11:11:55AM -0400, Gary Rookard wrote: > Renamed (1) prototype variable that was written in mixed case. > HTUpdateDefaultSetting -> ht_update_default_setting > > Linux kernel coding style "cleanup". > No change in runtime logic. > > Signed-off-by: Gary Rookard > --- > drivers/staging/rtl8192e/rtllib.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 5517b9df65be..1a3dd4dcad81 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -1807,7 +1807,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee, struct iw_request_info *info, > void HTSetConnectBwMode(struct rtllib_device *ieee, > enum ht_channel_width bandwidth, > enum ht_extchnl_offset Offset); > -void HTUpdateDefaultSetting(struct rtllib_device *ieee); > +void ht_update_default_setting(struct rtllib_device *ieee); > void HTConstructCapabilityElement(struct rtllib_device *ieee, > u8 *posHTCap, u8 *len, > u8 isEncrypt, bool bAssoc); > -- > 2.41.0 > > You just broke the build? Also, you sent 3 patches that do different things, yet have identical subject lines, that's obviously not correct. Please fix up and resend a v2 series. thanks, greg k-h